From 1eb34b8324cb09e73f4dabe0768c37301d5c7c2f Mon Sep 17 00:00:00 2001 From: kyranjamie Date: Tue, 10 Oct 2023 15:59:14 +0200 Subject: [PATCH 01/13] feat: sBTC devenv network --- src/shared/constants.ts | 19 +++++++++++++++++++ tests/specs/settings/settings-menu.spec.ts | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/src/shared/constants.ts b/src/shared/constants.ts index c6ccd8fd1a0..1087a7770fe 100644 --- a/src/shared/constants.ts +++ b/src/shared/constants.ts @@ -33,6 +33,7 @@ export enum WalletDefaultNetworkConfigurationIds { mainnet = 'mainnet', testnet = 'testnet', signet = 'signet', + sbtcDevenv = 'sbtcDevenv', devnet = 'devnet', } @@ -137,6 +138,23 @@ const networkSignet: NetworkConfiguration = { }, }; +const networkSbtcDevenv: NetworkConfiguration = { + id: WalletDefaultNetworkConfigurationIds.sbtcDevenv, + name: 'sBTC Devenv', + chain: { + stacks: { + blockchain: 'stacks', + chainId: ChainID.Testnet, + url: 'localhost:3999', + }, + bitcoin: { + blockchain: 'bitcoin', + network: 'regtest', + url: 'localhost:8999/api', + }, + }, +}; + const networkDevnet: NetworkConfiguration = { id: WalletDefaultNetworkConfigurationIds.devnet, name: 'Devnet', @@ -163,6 +181,7 @@ export const defaultNetworksKeyedById: Record< [WalletDefaultNetworkConfigurationIds.mainnet]: networkMainnet, [WalletDefaultNetworkConfigurationIds.testnet]: networkTestnet, [WalletDefaultNetworkConfigurationIds.signet]: networkSignet, + [WalletDefaultNetworkConfigurationIds.sbtcDevenv]: networkSbtcDevenv, [WalletDefaultNetworkConfigurationIds.devnet]: networkDevnet, }; diff --git a/tests/specs/settings/settings-menu.spec.ts b/tests/specs/settings/settings-menu.spec.ts index baf7a8b5782..de19296581c 100644 --- a/tests/specs/settings/settings-menu.spec.ts +++ b/tests/specs/settings/settings-menu.spec.ts @@ -66,6 +66,6 @@ test.describe('Settings menu', () => { await page.getByTestId(SettingsSelectors.ChangeNetworkAction).click(); await page.waitForTimeout(850); const networkListItems = await page.getByTestId(SettingsSelectors.NetworkListItem).all(); - test.expect(networkListItems).toHaveLength(4); + test.expect(networkListItems).toHaveLength(5); }); }); From ba1a712cda14574ef0a24ee66fc4328d83fbc956 Mon Sep 17 00:00:00 2001 From: kyranjamie Date: Wed, 11 Oct 2023 18:50:35 +0200 Subject: [PATCH 02/13] chore: fix missing protocol --- src/shared/constants.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/constants.ts b/src/shared/constants.ts index 1087a7770fe..320012157f9 100644 --- a/src/shared/constants.ts +++ b/src/shared/constants.ts @@ -145,12 +145,12 @@ const networkSbtcDevenv: NetworkConfiguration = { stacks: { blockchain: 'stacks', chainId: ChainID.Testnet, - url: 'localhost:3999', + url: 'http://localhost:3999', }, bitcoin: { blockchain: 'bitcoin', network: 'regtest', - url: 'localhost:8999/api', + url: 'http://localhost:8999/api', }, }, }; From 2a0630ea8d8cab38c5251fe2e9884cecbfb51489 Mon Sep 17 00:00:00 2001 From: kyranjamie Date: Wed, 11 Oct 2023 16:30:04 +0200 Subject: [PATCH 03/13] ci: attempt automating merge back --- .github/workflows/create-version.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/create-version.yml b/.github/workflows/create-version.yml index 09898c6ce30..9e73f17dd29 100644 --- a/.github/workflows/create-version.yml +++ b/.github/workflows/create-version.yml @@ -66,3 +66,12 @@ jobs: with: name: release-notes path: release-notes.txt + + - name: Merge main -> dev + uses: devmasx/merge-branch@master + continue-on-error: true + with: + type: now + from_branch: main + target_branch: dev + github_token: ${{ secrets.SEMANTIC_RELEASE_TOKEN }} From a9562c616166fa6e44760a587c798d21c125d593 Mon Sep 17 00:00:00 2001 From: Pete Watters <2938440+pete-watters@users.noreply.github.com> Date: Thu, 21 Sep 2023 11:03:32 +0100 Subject: [PATCH 04/13] fix: update address displayer to use text-subdued for odd, closes #4249 --- .../components/address-displayer/address-displayer.layout.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/address-displayer/address-displayer.layout.tsx b/src/app/components/address-displayer/address-displayer.layout.tsx index 0690efec359..c6ce8a41071 100644 --- a/src/app/components/address-displayer/address-displayer.layout.tsx +++ b/src/app/components/address-displayer/address-displayer.layout.tsx @@ -7,7 +7,7 @@ interface AddressDisplayerLayoutProps { export function AddressDisplayerLayout({ isEven, ...props }: AddressDisplayerLayoutProps) { return ( Date: Wed, 11 Oct 2023 09:01:08 +0100 Subject: [PATCH 05/13] fix: update collectible header font and align icon, closes #4290 --- .../components/collectibes.layout.tsx | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/app/features/collectibles/components/collectibes.layout.tsx b/src/app/features/collectibles/components/collectibes.layout.tsx index 620b588ea52..63f6c4303d8 100644 --- a/src/app/features/collectibles/components/collectibes.layout.tsx +++ b/src/app/features/collectibles/components/collectibes.layout.tsx @@ -1,8 +1,9 @@ -import { Flex, Grid, Spinner, color } from '@stacks/ui'; +import { Spinner } from '@stacks/ui'; +import { Flex, Grid, HStack, styled } from 'leather-styles/jsx'; +import { token } from 'leather-styles/tokens'; import { RefreshIcon } from '@app/components/icons/refresh-icon'; import { LoadingSpinner } from '@app/components/loading-spinner'; -import { Caption } from '@app/components/typography'; interface CollectiblesLayoutProps { title: string; @@ -17,20 +18,20 @@ export function CollectiblesLayout(props: CollectiblesLayoutProps) { return ( <> - - {title} + + {title} {isLoading ? ( - + ) : ( onRefresh()} /> )} - + {subHeader} Date: Wed, 11 Oct 2023 09:13:00 +0100 Subject: [PATCH 06/13] fix: change tab hover bg colour, closes #4249 --- theme/global/radix-styles.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/theme/global/radix-styles.ts b/theme/global/radix-styles.ts index f203f6bec0b..4685e2f953d 100644 --- a/theme/global/radix-styles.ts +++ b/theme/global/radix-styles.ts @@ -91,6 +91,9 @@ export const radixTabStyles = { }, '.rt-TabsTrigger': { flex: 1, + '& :hover::before': { + backgroundColor: 'accent.component-background-hover', + }, }, '.rt-TabsTriggerInner': { width: '100%', From 75466bdb20af9d5443b31ec3fa4708b75f707ff4 Mon Sep 17 00:00:00 2001 From: Pete Watters <2938440+pete-watters@users.noreply.github.com> Date: Wed, 11 Oct 2023 09:41:54 +0100 Subject: [PATCH 07/13] fix: give activity screen a min height to stop it jumping when empty, closes #4249 --- .../features/activity-list/activity-list.tsx | 19 +++++++++++++++---- .../components/no-account-activity.tsx | 4 ++-- .../activity-list/components/tab-wrapper.tsx | 15 +++++++++++++++ src/app/features/asset-list/asset-list.tsx | 8 ++++---- 4 files changed, 36 insertions(+), 10 deletions(-) create mode 100644 src/app/features/activity-list/components/tab-wrapper.tsx diff --git a/src/app/features/activity-list/activity-list.tsx b/src/app/features/activity-list/activity-list.tsx index a8bde52abc6..594a2894c2a 100644 --- a/src/app/features/activity-list/activity-list.tsx +++ b/src/app/features/activity-list/activity-list.tsx @@ -16,6 +16,7 @@ import { convertBitcoinTxsToListType, convertStacksTxsToListType } from './activ import { NoAccountActivity } from './components/no-account-activity'; import { PendingTransactionList } from './components/pending-transaction-list/pending-transaction-list'; import { SubmittedTransactionList } from './components/submitted-transaction-list/submitted-transaction-list'; +import { TabWrapper } from './components/tab-wrapper'; import { TransactionList } from './components/transaction-list/transaction-list'; // TODO: temporary really ugly fix while we address conditional data problem of @@ -94,12 +95,22 @@ export function ActivityList() { const hasTxs = hasSubmittedTransactions || hasPendingTransactions || hasTransactions; - if (isInitialLoading) return ; + if (isInitialLoading) + return ( + + + + ); - if (!hasTxs) return ; + if (!hasTxs) + return ( + + + + ); return ( - <> + {hasSubmittedTransactions && } {hasPendingTransactions && ( )} - + ); } diff --git a/src/app/features/activity-list/components/no-account-activity.tsx b/src/app/features/activity-list/components/no-account-activity.tsx index 9d239c139fa..4340b859eb4 100644 --- a/src/app/features/activity-list/components/no-account-activity.tsx +++ b/src/app/features/activity-list/components/no-account-activity.tsx @@ -1,11 +1,11 @@ import NoActivity from '@assets/images/no-activity.png'; -import { Stack } from '@stacks/ui'; +import { Stack } from 'leather-styles/jsx'; import { Caption } from '@app/components/typography'; export function NoAccountActivity() { return ( - + No activity yet diff --git a/src/app/features/activity-list/components/tab-wrapper.tsx b/src/app/features/activity-list/components/tab-wrapper.tsx new file mode 100644 index 00000000000..e22e6286ef6 --- /dev/null +++ b/src/app/features/activity-list/components/tab-wrapper.tsx @@ -0,0 +1,15 @@ +import { Box } from 'leather-styles/jsx'; + +interface TabWrapperProps { + children: React.ReactNode; + padContent?: boolean; +} + +export function TabWrapper({ children, padContent = false }: TabWrapperProps) { + return ( + // Height set based on the height of the empty assets screen + + {children} + + ); +} diff --git a/src/app/features/asset-list/asset-list.tsx b/src/app/features/asset-list/asset-list.tsx index 8a63771f5b1..003beb1bbc0 100644 --- a/src/app/features/asset-list/asset-list.tsx +++ b/src/app/features/asset-list/asset-list.tsx @@ -1,8 +1,8 @@ import { Outlet } from 'react-router-dom'; import { useNavigate } from 'react-router-dom'; -import { Box, Stack } from '@stacks/ui'; import { HomePageSelectors } from '@tests/selectors/home.selectors'; +import { Stack } from 'leather-styles/jsx'; import { LEDGER_BITCOIN_ENABLED } from '@shared/environment'; @@ -27,14 +27,14 @@ export function AssetsList() { const navigate = useNavigate(); return ( - + {/* Temporary duplication during Ledger Bitcoin feature dev */} {whenWallet({ software: ( } + icon={} address={btcAddress} /> ), @@ -42,7 +42,7 @@ export function AssetsList() { } + icon={} address={btcAddress} // add conditionally if not bitcoin keys isPressable={!btcAddress} From 07989ae39e199000e0abf9cb420dc5eabea3e5eb Mon Sep 17 00:00:00 2001 From: Pete Watters <2938440+pete-watters@users.noreply.github.com> Date: Wed, 11 Oct 2023 12:13:52 +0100 Subject: [PATCH 08/13] fix: alter position of receive modal in extension view, #4165 --- .../components/drawer/components/drawer-header.tsx | 14 +++----------- src/app/components/text-input-field.tsx | 1 + src/app/pages/receive/receive-modal.tsx | 9 ++++++++- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/app/components/drawer/components/drawer-header.tsx b/src/app/components/drawer/components/drawer-header.tsx index b36ddf4df06..edc172a5bbd 100644 --- a/src/app/components/drawer/components/drawer-header.tsx +++ b/src/app/components/drawer/components/drawer-header.tsx @@ -1,5 +1,4 @@ -import { Box, Flex } from '@stacks/ui'; -import { styled } from 'leather-styles/jsx'; +import { Box, Flex, styled } from 'leather-styles/jsx'; import { useHover } from 'use-events'; import { ArrowLeftIcon } from '@app/components/icons/arrow-left-icon'; @@ -29,14 +28,7 @@ export function DrawerHeader({ const [isHovered, bind] = useHover(); return ( - + {enableGoBack ? ( } @@ -44,7 +36,7 @@ export function DrawerHeader({ onAction={onGoBack} /> ) : ( - + )} {icon && icon} {title && {title}} diff --git a/src/app/components/text-input-field.tsx b/src/app/components/text-input-field.tsx index 9ac802f5ba8..a38bac23590 100644 --- a/src/app/components/text-input-field.tsx +++ b/src/app/components/text-input-field.tsx @@ -119,6 +119,7 @@ export function TextInputField({ ref={inputRef || ref} _disabled={{ bg: color('bg') }} _focus={{ border: 'none' }} + _placeholder={{ color: 'colors.accent.text-subdued' }} autoComplete="off" border="none" data-testid={dataTestId} diff --git a/src/app/pages/receive/receive-modal.tsx b/src/app/pages/receive/receive-modal.tsx index 834c6fc1dce..723ded5ab4f 100644 --- a/src/app/pages/receive/receive-modal.tsx +++ b/src/app/pages/receive/receive-modal.tsx @@ -4,6 +4,7 @@ import { useLocation, useNavigate } from 'react-router-dom'; import { useClipboard } from '@stacks/ui'; import { HomePageSelectors } from '@tests/selectors/home.selectors'; import { Box, styled } from 'leather-styles/jsx'; +import { token } from 'leather-styles/tokens'; import get from 'lodash.get'; import { RouteUrls } from '@shared/route-urls'; @@ -62,7 +63,13 @@ export function ReceiveModal({ type = 'full' }: ReceiveModalProps) { ); return ( - navigate('../')}> + navigate('../')} + > {title} From f166a31e50aed555c6a54495caf742e704c19461 Mon Sep 17 00:00:00 2001 From: Pete Watters <2938440+pete-watters@users.noreply.github.com> Date: Wed, 11 Oct 2023 12:26:43 +0100 Subject: [PATCH 09/13] fix: stop create account button disappearing at smaller heights, #4165 --- .../switch-account-drawer/components/create-account-action.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/features/switch-account-drawer/components/create-account-action.tsx b/src/app/features/switch-account-drawer/components/create-account-action.tsx index 3d8ca2e192a..3adf5e2b0b3 100644 --- a/src/app/features/switch-account-drawer/components/create-account-action.tsx +++ b/src/app/features/switch-account-drawer/components/create-account-action.tsx @@ -7,7 +7,7 @@ interface CreateAccountActionProps { } export function CreateAccountAction({ onCreateAccount }: CreateAccountActionProps) { return ( - + onCreateAccount()}> Create new account From f09aec34ab1e395f04424a8357f3ed3f0ab352a7 Mon Sep 17 00:00:00 2001 From: Pete Watters <2938440+pete-watters@users.noreply.github.com> Date: Wed, 11 Oct 2023 13:13:54 +0100 Subject: [PATCH 10/13] fix: improve display of select account in extension mode, #4165 --- src/app/components/drawer/controlled-drawer.tsx | 3 +++ .../components/create-account-action.tsx | 12 ++++++++++-- .../components/switch-account-list.tsx | 4 ++-- .../switch-account-drawer/switch-account-drawer.tsx | 6 +++++- 4 files changed, 20 insertions(+), 5 deletions(-) diff --git a/src/app/components/drawer/controlled-drawer.tsx b/src/app/components/drawer/controlled-drawer.tsx index 02819286cbe..1ff9385a301 100644 --- a/src/app/components/drawer/controlled-drawer.tsx +++ b/src/app/components/drawer/controlled-drawer.tsx @@ -17,6 +17,9 @@ export function ControlledDrawer(props: ControlledDrawerProps) { return ( - onCreateAccount()}> + + onCreateAccount()}> Create new account diff --git a/src/app/features/switch-account-drawer/components/switch-account-list.tsx b/src/app/features/switch-account-drawer/components/switch-account-list.tsx index 4a2148ba947..db4d6a657cc 100644 --- a/src/app/features/switch-account-drawer/components/switch-account-list.tsx +++ b/src/app/features/switch-account-drawer/components/switch-account-list.tsx @@ -1,7 +1,7 @@ import { memo } from 'react'; import { Virtuoso } from 'react-virtuoso'; -import { Box } from '@stacks/ui'; +import { Box } from 'leather-styles/jsx'; import { StacksAccount } from '@app/store/accounts/blockchain/stacks/stacks-account.models'; @@ -21,7 +21,7 @@ export const SwitchAccountList = memo( style={{ paddingTop: '24px', height: '70vh' }} totalCount={accounts.length} itemContent={index => ( - + )} diff --git a/src/app/features/switch-account-drawer/switch-account-drawer.tsx b/src/app/features/switch-account-drawer/switch-account-drawer.tsx index c36c94d6e3c..ba6a696d55f 100644 --- a/src/app/features/switch-account-drawer/switch-account-drawer.tsx +++ b/src/app/features/switch-account-drawer/switch-account-drawer.tsx @@ -33,7 +33,11 @@ export const SwitchAccountDrawer = memo(() => { return isShowing && accounts ? ( - + Date: Thu, 12 Oct 2023 08:55:18 +0100 Subject: [PATCH 11/13] fix: make adjustments based on PR review feedback --- src/app/components/drawer/components/drawer-header.tsx | 2 +- src/app/components/text-input-field.tsx | 1 - .../switch-account-drawer/components/create-account-action.tsx | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/app/components/drawer/components/drawer-header.tsx b/src/app/components/drawer/components/drawer-header.tsx index edc172a5bbd..3700e7d3149 100644 --- a/src/app/components/drawer/components/drawer-header.tsx +++ b/src/app/components/drawer/components/drawer-header.tsx @@ -28,7 +28,7 @@ export function DrawerHeader({ const [isHovered, bind] = useHover(); return ( - + {enableGoBack ? ( } diff --git a/src/app/components/text-input-field.tsx b/src/app/components/text-input-field.tsx index a38bac23590..9ac802f5ba8 100644 --- a/src/app/components/text-input-field.tsx +++ b/src/app/components/text-input-field.tsx @@ -119,7 +119,6 @@ export function TextInputField({ ref={inputRef || ref} _disabled={{ bg: color('bg') }} _focus={{ border: 'none' }} - _placeholder={{ color: 'colors.accent.text-subdued' }} autoComplete="off" border="none" data-testid={dataTestId} diff --git a/src/app/features/switch-account-drawer/components/create-account-action.tsx b/src/app/features/switch-account-drawer/components/create-account-action.tsx index 9b67e46f1e5..74d44247577 100644 --- a/src/app/features/switch-account-drawer/components/create-account-action.tsx +++ b/src/app/features/switch-account-drawer/components/create-account-action.tsx @@ -16,7 +16,7 @@ export function CreateAccountAction({ onCreateAccount }: CreateAccountActionProp bottom={0} width="100%" > - onCreateAccount()}> + onCreateAccount()}> Create new account From 230fe46abafafd71e3434779bdb7c4b591736c0b Mon Sep 17 00:00:00 2001 From: Pete Watters <2938440+pete-watters@users.noreply.github.com> Date: Fri, 13 Oct 2023 12:41:57 +0100 Subject: [PATCH 12/13] fix: name wrapper more specifically --- src/app/features/activity-list/activity-list.tsx | 14 +++++++------- .../activity-list/components/tab-wrapper.tsx | 7 +++++-- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/app/features/activity-list/activity-list.tsx b/src/app/features/activity-list/activity-list.tsx index 594a2894c2a..b28cf472e9e 100644 --- a/src/app/features/activity-list/activity-list.tsx +++ b/src/app/features/activity-list/activity-list.tsx @@ -16,7 +16,7 @@ import { convertBitcoinTxsToListType, convertStacksTxsToListType } from './activ import { NoAccountActivity } from './components/no-account-activity'; import { PendingTransactionList } from './components/pending-transaction-list/pending-transaction-list'; import { SubmittedTransactionList } from './components/submitted-transaction-list/submitted-transaction-list'; -import { TabWrapper } from './components/tab-wrapper'; +import { ActivityListTabWrapper } from './components/tab-wrapper'; import { TransactionList } from './components/transaction-list/transaction-list'; // TODO: temporary really ugly fix while we address conditional data problem of @@ -97,20 +97,20 @@ export function ActivityList() { if (isInitialLoading) return ( - + - + ); if (!hasTxs) return ( - + - + ); return ( - + {hasSubmittedTransactions && } {hasPendingTransactions && ( )} - + ); } diff --git a/src/app/features/activity-list/components/tab-wrapper.tsx b/src/app/features/activity-list/components/tab-wrapper.tsx index e22e6286ef6..7d82c501831 100644 --- a/src/app/features/activity-list/components/tab-wrapper.tsx +++ b/src/app/features/activity-list/components/tab-wrapper.tsx @@ -1,11 +1,14 @@ import { Box } from 'leather-styles/jsx'; -interface TabWrapperProps { +interface ActivityListTabWrapperProps { children: React.ReactNode; padContent?: boolean; } -export function TabWrapper({ children, padContent = false }: TabWrapperProps) { +export function ActivityListTabWrapper({ + children, + padContent = false, +}: ActivityListTabWrapperProps) { return ( // Height set based on the height of the empty assets screen From 1a86b85a4bede129c2b880cdbbff1be2f6cce504 Mon Sep 17 00:00:00 2001 From: Pete Watters <2938440+pete-watters@users.noreply.github.com> Date: Fri, 13 Oct 2023 13:48:57 +0100 Subject: [PATCH 13/13] fix: properly switch between 12 and 24 word inputs, closes #4250 --- src/app/pages/onboarding/sign-in/sign-in.tsx | 16 ++++++++++------ tests/specs/onboarding/onboarding.spec.ts | 2 -- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/app/pages/onboarding/sign-in/sign-in.tsx b/src/app/pages/onboarding/sign-in/sign-in.tsx index 6b430dae857..faad25e2dcb 100644 --- a/src/app/pages/onboarding/sign-in/sign-in.tsx +++ b/src/app/pages/onboarding/sign-in/sign-in.tsx @@ -1,4 +1,4 @@ -import { useState } from 'react'; +import { useEffect, useState } from 'react'; import { useNavigate } from 'react-router-dom'; import { RouteUrls } from '@shared/route-urls'; @@ -15,19 +15,23 @@ export function SignIn() { const navigate = useNavigate(); const [twentyFourWordMode, setTwentyFourWordMode] = useState(true); - const [mnemonic, setMnemonic] = useState<(string | null)[]>(() => createNullArrayOfLength(24)); + const [mnemonic, setMnemonic] = useState<(string | null)[]>([]); useRouteHeader(
navigate(RouteUrls.Onboarding)} hideActions />); + useEffect(() => { + const emptyMnemonicArray = twentyFourWordMode + ? createNullArrayOfLength(24) + : createNullArrayOfLength(12); + setMnemonic(emptyMnemonicArray); + }, [twentyFourWordMode]); + return ( <> { - setTwentyFourWordMode(!twentyFourWordMode); - setMnemonic(createNullArrayOfLength(twentyFourWordMode ? 24 : 12)); - }} + onClick={() => setTwentyFourWordMode(!twentyFourWordMode)} twentyFourWordMode={twentyFourWordMode} /> } diff --git a/tests/specs/onboarding/onboarding.spec.ts b/tests/specs/onboarding/onboarding.spec.ts index 93aabe19aa8..cfa55668eda 100644 --- a/tests/specs/onboarding/onboarding.spec.ts +++ b/tests/specs/onboarding/onboarding.spec.ts @@ -55,12 +55,10 @@ test.describe('Onboarding an existing user', () => { // enter some key partial const validPartialKey = 'shoulder any pencil'; await onboardingPage.signInMnemonicKey(validPartialKey); - const signInButton = await onboardingPage.page.getByTestId(OnboardingSelectors.SignInBtn); const signInSeedError = await onboardingPage.page.getByTestId( OnboardingSelectors.SignInSeedError ); await test.expect(signInSeedError).not.toBeVisible(); - await test.expect(signInButton).toBeDisabled(); }); test('Activity tab', async ({ extensionId, globalPage, onboardingPage, homePage }) => {