Add API to request addresses

[kyranjamie]

Similar to Ethereum's eth_requestAccounts, the Hiro Wallet should provide a way to share account details that doesn't do auth, requiring signing of a JWT.

Related MetaMask/metamask-extension#4703

[markmhendrickson]

Related discussions: #2352 #1051 (comment)

[markmhendrickson]

Note how the equivalent MetaMask UI appears to preselect just the currently / previously selected account in the user's session:

@landitus we'll need a similar modal for the wallet to support this issue's functionality

Note that they have a second screen here that clarifies permissions, though I imagine we won't need one in our case since we can fit whatever guidance we need into just one screen (in which the user selects the accounts to share):

[landitus]

Thanks @markmhx. I'll include this scenario as I work on #2355

[landitus]

Note how the equivalent MetaMask UI appears to preselect just the currently / previously selected account in the user's session:

• Would the multiple account selection functionality just be available when the dApp requests the account details (this issue) and also when using the authentication methods?
• Is selecting multiple accounts selection functionality a hardware wallet-specific feature? Why?

Trying to understand how the Connect wallet UX would evolve with this new method and if they should be treated as different UX patterns.

[markmhendrickson]

Would the multiple account selection functionality just be available when the dApp requests the account details (this issue) and also when using the authentication methods?

Just when the app requests accounts with the new API for requestAccounts or similar.

Is selecting multiple accounts selection functionality a hardware wallet-specific feature? Why?

Nope, multiple accounts can be selected regardless of whether the user is using a software or hardware wallet.

Trying to understand how the Connect wallet UX would evolve with this new method and if they should be treated as different UX patterns.

I suspect that the app will show the same sort of "Connect wallet" option to users, regardless of whether they decide to trigger the new requestAccounts method or the old (and soon deprecated) authentication method.

Both are ways to connect the wallet. They just differ in A) whether the account(s) are verified or not, and B) whether only a single account or multiple account values can be returned to the app as a result.

[svntax]

Having something like eth_requestAccounts for stacks wallets would be very helpful for web games made in game engines like Unity and Godot. In many cases, reading the list of NFTs that an account owns is enough for a game to use those NFTs. I'm personally interested in adding Stacks wallet support in Godot, so I'd love to see this implemented.

[markmhendrickson]

@kyranjamie @mica000 putting this back on the board as WIP

[markmhendrickson]

Now inclusive of taproot addresses: #3372

• Stacks
• Native SegWit
• Taproot

[markmhendrickson]

Now supported via #3421