-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support app requests to sign BTC transactions #2824
Comments
@mica000 I believe the main thing missing from this early mockup is the ability to set fees, which we could drop in above the send button: |
Choosing a BTC fee has been updated on a separate user flow: |
Makes sense! Mind updating this initial screen e.g. removing fees and total since that'll come later? I imagine you have ideas for how to spruce it up in general, too. |
1 similar comment
Makes sense! Mind updating this initial screen e.g. removing fees and total since that'll come later? I imagine you have ideas for how to spruce it up in general, too. |
I've modified this issue to include both fully and partially signed transactions, either broadcasted by the wallet or simply returned to the app. |
@radicleart would use this immediately for sBTC bridge bitcoin transactions. |
Looks generally good! Though we should move the fee setting to a subsequent modal just like we want it for regular BTC sends in the wallet, yea? |
Also header should be more like "Send Bitcoin" than "buy-in-ustx" And note how we'll have the app's domain (and favicon) here but not its name per se. |
would this enable us to do a tx with both segwit and taproot address? example: payment with btc I tried implementing this using PSBT, but failed miserably. |
@crypticmeta Yep! We intend for it to work with both types. |
As raised on hirosystems/connect#283 and previewed with https://twitter.com/markymark/status/1582379165168254977
SIP needed: stacksgov/sips#105
The text was updated successfully, but these errors were encountered: