Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support app requests to sign BTC transactions #2824

Closed
markmhendrickson opened this issue Nov 8, 2022 · 15 comments · Fixed by #3563
Closed

Support app requests to sign BTC transactions #2824

markmhendrickson opened this issue Nov 8, 2022 · 15 comments · Fixed by #3563
Assignees
Labels
area:bitcoin enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Nov 8, 2022

As raised on hirosystems/connect#283 and previewed with https://twitter.com/markymark/status/1582379165168254977

SIP needed: stacksgov/sips#105

image

@markmhendrickson
Copy link
Collaborator Author

@mica000 I believe the main thing missing from this early mockup is the ability to set fees, which we could drop in above the send button:

Image

@fbwoolf fbwoolf moved this from Assigned to WIP in Hiro Wallet (DEPRECATED) Feb 14, 2023
@fbwoolf fbwoolf moved this from WIP to Assigned in Hiro Wallet (DEPRECATED) Feb 14, 2023
@fbwoolf fbwoolf moved this from Assigned to WIP in Hiro Wallet (DEPRECATED) Feb 14, 2023
@fbwoolf fbwoolf moved this from WIP to Assigned in Hiro Wallet (DEPRECATED) Feb 14, 2023
@markmhendrickson
Copy link
Collaborator Author

Relevant to this work in anticipation of extended functionality: BIP-0322 and BIP-0174

@mica000
Copy link

mica000 commented Feb 16, 2023

Choosing a BTC fee has been updated on a separate user flow:
https://www.figma.com/file/OSQocEEJnfcMkniEl8u3U8/%231483---Initial-Bitcoin-support?node-id=1110%3A54471&t=Shl5eSB4xRFAbQkH-4

@markmhendrickson
Copy link
Collaborator Author

Makes sense! Mind updating this initial screen e.g. removing fees and total since that'll come later? I imagine you have ideas for how to spruce it up in general, too.

1 similar comment
@markmhendrickson
Copy link
Collaborator Author

Makes sense! Mind updating this initial screen e.g. removing fees and total since that'll come later? I imagine you have ideas for how to spruce it up in general, too.

@fbwoolf fbwoolf self-assigned this Feb 25, 2023
@fbwoolf fbwoolf moved this from Assigned to WIP in Hiro Wallet (DEPRECATED) Feb 25, 2023
@markmhendrickson markmhendrickson changed the title Support app requests to broadcast BTC transactions Support app requests to sign BTC transactions Feb 28, 2023
@markmhendrickson
Copy link
Collaborator Author

I've modified this issue to include both fully and partially signed transactions, either broadcasted by the wallet or simply returned to the app.

@markmhendrickson
Copy link
Collaborator Author

Speaking with @mica000 about this, it's like the new confirmation screen found here but will a standardized app request header unit:

Image

@igorsyl
Copy link

igorsyl commented Mar 11, 2023

@radicleart would use this immediately for sBTC bridge bitcoin transactions.

@fbwoolf fbwoolf moved this from WIP to Assigned in Hiro Wallet (DEPRECATED) Mar 14, 2023
@markmhendrickson
Copy link
Collaborator Author

Looks generally good! Though we should move the fee setting to a subsequent modal just like we want it for regular BTC sends in the wallet, yea?

@markmhendrickson
Copy link
Collaborator Author

Also header should be more like "Send Bitcoin" than "buy-in-ustx"

And note how we'll have the app's domain (and favicon) here but not its name per se.

@mica000
Copy link

mica000 commented Mar 20, 2023

Updated design: https://www.figma.com/file/OSQocEEJnfcMkniEl8u3U8/%231483---Initial-Bitcoin-support?node-id=2348-92231&t=CDUjNDev3ezZG5Su-4

@markmhendrickson
Copy link
Collaborator Author

@mica000 hmm relevant how so? I'd say replace with whatever design you want implemented these days. I don't believe @fbwoolf has started on this UI work yet iirc

@fbwoolf
Copy link
Contributor

fbwoolf commented Mar 21, 2023

@mica000 hmm relevant how so? I'd say replace with whatever design you want implemented these days. I don't believe @fbwoolf has started on this UI work yet iirc

Nope, I haven't started this yet.

@crypticmeta
Copy link

would this enable us to do a tx with both segwit and taproot address?

example:

payment with btc
receive ordinal with taproot

I tried implementing this using PSBT, but failed miserably.

@markmhendrickson
Copy link
Collaborator Author

@crypticmeta Yep! We intend for it to work with both types.

@fbwoolf fbwoolf moved this from Assigned to WIP in Hiro Wallet (DEPRECATED) Apr 13, 2023
@fbwoolf fbwoolf linked a pull request Apr 17, 2023 that will close this issue
@fbwoolf fbwoolf moved this from WIP to Review in Hiro Wallet (DEPRECATED) Apr 20, 2023
@fbwoolf fbwoolf moved this from Review to QA in Hiro Wallet (DEPRECATED) Apr 21, 2023
@fbwoolf fbwoolf moved this from QA to Ready to release in Hiro Wallet (DEPRECATED) Apr 24, 2023
@markmhendrickson markmhendrickson moved this from Ready to release to Released in Hiro Wallet (DEPRECATED) May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:bitcoin enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants