Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Ordinal inscriptions alongside Stacks NFTs #3090

Closed
markmhendrickson opened this issue Feb 12, 2023 · 3 comments · Fixed by #3164
Closed

Display Ordinal inscriptions alongside Stacks NFTs #3090

markmhendrickson opened this issue Feb 12, 2023 · 3 comments · Fixed by #3164
Assignees
Labels
area:collectibles Issues related to non-fungible tokens (NFTs) area:ordinals enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Feb 12, 2023

To complement the release of #1028

@markmhendrickson markmhendrickson converted this from a draft issue Feb 12, 2023
@markmhendrickson markmhendrickson added area:collectibles Issues related to non-fungible tokens (NFTs) area:ordinals labels Feb 12, 2023
@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p2 Critical functionality needed by few users, with no clear alternatives labels Feb 12, 2023
@markmhendrickson markmhendrickson changed the title Display Ordinals alongside Stacks NFTs Display Ordinal inscriptions alongside Stacks NFTs Feb 16, 2023
@markmhendrickson markmhendrickson moved this from Assigned to WIP in Hiro Wallet (DEPRECATED) Feb 16, 2023
@markmhendrickson
Copy link
Collaborator Author

@mica000 copying your designs guidance here since this issue is Ordinals-specific: #1028 (comment)

@markmhendrickson
Copy link
Collaborator Author

I'm reopening because the API endpoint on which we're depending here (https://ordapi.xyz/address/${address}) seems very non-performant and I can't get my inscriptions to load. Thankfully these (or similar) in combination should work for us:

  1. We query a generic blockchain API (mempool or blockstream in our case?) in a similar manner to how they're hitting up https://api.blockcypher.com/v1/btc/main/addrs/bc1ptxztnn7yuv2c2hz5p6lxwyccv8z3yzw8ntzv6afpjqqn5qp920ms5vscmv?unspentOnly=true&limit=50 to get unspent transactions for the address and cherrypick the first to appear
  2. Then we pass that tx_hash to https://ordapi.xyz/output/ca84578e541353673a66608d7d95608e48a7cdce7830f638efd0214f538e6842:0 to get the inscription ID
  3. Then we use the inscription ID to query https://ordapi.xyz/inscription/9f165f481c23ba6eab848618bfebed149a43950d96ca053ae53ae7a54d3d3b70i0 for the inscription metadata and https://ordinals.com/content/9f165f481c23ba6eab848618bfebed149a43950d96ca053ae53ae7a54d3d3b70i0 for its content

@diwakergupta
Copy link

FYI @rafaelcr

@markmhendrickson markmhendrickson moved this from Review to Ready to release in Hiro Wallet (DEPRECATED) Feb 20, 2023
@markmhendrickson markmhendrickson moved this from Ready to release to Released in Hiro Wallet (DEPRECATED) Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collectibles Issues related to non-fungible tokens (NFTs) area:ordinals enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants