Fix state change behavior upon selecting "Send" for inscription #4028
Assignees
Labels
area:ordinals
area:send
bug
Functionality broken
bug-p3
Non-critical functionality broken for many users, or there are clear workarounds
effort:medium
Expected to take 2-5 days of integration work
Comments
markmhendrickson
added
bug
github-project-automation
bot
moved this to Enhancements backlog
in Hiro Wallet (DEPRECATED)
markmhendrickson
moved this from Enhancements backlog
to Triage
in Hiro Wallet (DEPRECATED)
|
Assigning @pete-watters as this is related to the routing changes. Think there must be some router setting to not unmount the activity route when loading a modal? |
pete-watters
added a commit
that referenced
this issue
Jul 26, 2023
pete-watters
added a commit
that referenced
this issue
Jul 26, 2023
pete-watters
added a commit
that referenced
this issue
Jul 27, 2023
pete-watters
added a commit
that referenced
this issue
Jul 27, 2023
pete-watters
added a commit
that referenced
this issue
Jul 27, 2023
pete-watters
added a commit
that referenced
this issue
Jul 27, 2023
pete-watters
added a commit
that referenced
this issue
Jul 27, 2023
pete-watters
added
the
effort:medium
pete-watters
added a commit
that referenced
this issue
Jul 27, 2023
|
@pete-watters are you working on |
I have a PR open here |
pete-watters
added a commit
that referenced
this issue
Aug 4, 2023
pete-watters
added a commit
that referenced
this issue
Aug 4, 2023
pete-watters
added a commit
that referenced
this issue
Aug 4, 2023
pete-watters
added a commit
that referenced
this issue
Aug 4, 2023
pete-watters
added a commit
that referenced
this issue
Aug 14, 2023
pete-watters
added a commit
that referenced
this issue
Oct 9, 2023
pete-watters
added a commit
that referenced
this issue
Oct 11, 2023
pete-watters
added a commit
that referenced
this issue
Oct 12, 2023
pete-watters
added a commit
that referenced
this issue
Oct 13, 2023
Merged
kyranjamie
pushed a commit
that referenced
this issue
Oct 24, 2023
## [6.12.0](v6.11.0...v6.12.0) (2023-10-24) ### Features * add connect btn ([3903ba1](3903ba1)) * add unsupported browsers modal ([2febd49](2febd49)) * added bitcoin contract list page and entry point ([a28678d](a28678d)) * added tests for bitcoin contract request ([157f97e](157f97e)) * return addresses of regtest and signet ([a0717e3](a0717e3)) * rework onboarding ledger flow, closes [#4281](#4281) ([47aa2e2](47aa2e2)) ### Bug Fixes * align text and caption left so it appears correctly in extension view ([bd25751](bd25751)) * allow direct access to /receive/stx ([e7c8d8d](e7c8d8d)) * change acc bug ([ce13789](ce13789)) * clean code ([77a4822](77a4822)) * clean code, add note re ordinals modal ([a06aa39](a06aa39)) * clean code, add note re ordinals modal ([993df34](993df34)) * close original recieve modal before opening qr code modal to prevent double modal ([10b7246](10b7246)) * code spanning past viewport width ([db35a49](db35a49)) * do not nest recieve sub routes to prevent double overlay of modal and maintain direct access ([1477c96](1477c96)) * enable bg redirect to overlay modal in new tab ([36c969f](36c969f)) * get build passing ([5826143](5826143)) * improve type loading ([d79ee62](d79ee62)) * ledger tx sign error process ([618923f](618923f)) * pass child routes as children to appease dep cruiser ([200907a](200907a)) * re-introduce bg location for hometabs so modals overlay on top of activity ([12571b0](12571b0)) * refactor modals to overlay on top of backgroundLocation consistently, closes [#4028](#4028) ([c006894](c006894)) * revert drawer changes from brand audit, closes [#4249](#4249) ([e437710](e437710)) * update path to receive stx to fix test ([2c897ab](2c897ab)) * use bg location to open in new tab. share modal bg logic ([07c5c98](07c5c98)) * use grid for asset rows to stop overflow while allowing width, closes [#4171](#4171) ([529c03d](529c03d)) * use independant route for FundReceiveStx ([e4bfd24](e4bfd24)) * use network.chain.bitcoin.url in api hooks, closes [#4330](#4330) ([ceaf228](ceaf228)) * wallet type definition ([ddc91e3](ddc91e3)) * welcome page header padding, closes [#4374](#4374) ([0817a5e](0817a5e)) ### Internal * debug window close util ([77056e7](77056e7)) * deprecate unused routes ([a3710c5](a3710c5)) * explore routing issues ([0dbbdcf](0dbbdcf)) * local copyToClipboard hook ([017fa3a](017fa3a)) * psbt stackui layout ([e71e457](e71e457))
pete-watters
added a commit
to Nithishvb/extension
that referenced
this issue
Jan 17, 2024
pete-watters
pushed a commit
to Nithishvb/extension
that referenced
this issue
Jan 17, 2024
## [6.12.0](leather-io/extension@v6.11.0...v6.12.0) (2023-10-24) ### Features * add connect btn ([3903ba1](leather-io@3903ba1)) * add unsupported browsers modal ([2febd49](leather-io@2febd49)) * added bitcoin contract list page and entry point ([a28678d](leather-io@a28678d)) * added tests for bitcoin contract request ([157f97e](leather-io@157f97e)) * return addresses of regtest and signet ([a0717e3](leather-io@a0717e3)) * rework onboarding ledger flow, closes [leather-io#4281](leather-io#4281) ([47aa2e2](leather-io@47aa2e2)) ### Bug Fixes * align text and caption left so it appears correctly in extension view ([bd25751](leather-io@bd25751)) * allow direct access to /receive/stx ([e7c8d8d](leather-io@e7c8d8d)) * change acc bug ([ce13789](leather-io@ce13789)) * clean code ([77a4822](leather-io@77a4822)) * clean code, add note re ordinals modal ([a06aa39](leather-io@a06aa39)) * clean code, add note re ordinals modal ([993df34](leather-io@993df34)) * close original recieve modal before opening qr code modal to prevent double modal ([10b7246](leather-io@10b7246)) * code spanning past viewport width ([db35a49](leather-io@db35a49)) * do not nest recieve sub routes to prevent double overlay of modal and maintain direct access ([1477c96](leather-io@1477c96)) * enable bg redirect to overlay modal in new tab ([36c969f](leather-io@36c969f)) * get build passing ([5826143](leather-io@5826143)) * improve type loading ([d79ee62](leather-io@d79ee62)) * ledger tx sign error process ([618923f](leather-io@618923f)) * pass child routes as children to appease dep cruiser ([200907a](leather-io@200907a)) * re-introduce bg location for hometabs so modals overlay on top of activity ([12571b0](leather-io@12571b0)) * refactor modals to overlay on top of backgroundLocation consistently, closes [leather-io#4028](leather-io#4028) ([c006894](leather-io@c006894)) * revert drawer changes from brand audit, closes [leather-io#4249](leather-io#4249) ([e437710](leather-io@e437710)) * update path to receive stx to fix test ([2c897ab](leather-io@2c897ab)) * use bg location to open in new tab. share modal bg logic ([07c5c98](leather-io@07c5c98)) * use grid for asset rows to stop overflow while allowing width, closes [leather-io#4171](leather-io#4171) ([529c03d](leather-io@529c03d)) * use independant route for FundReceiveStx ([e4bfd24](leather-io@e4bfd24)) * use network.chain.bitcoin.url in api hooks, closes [leather-io#4330](leather-io#4330) ([ceaf228](leather-io@ceaf228)) * wallet type definition ([ddc91e3](leather-io@ddc91e3)) * welcome page header padding, closes [leather-io#4374](leather-io#4374) ([0817a5e](leather-io@0817a5e)) ### Internal * debug window close util ([77056e7](leather-io@77056e7)) * deprecate unused routes ([a3710c5](leather-io@a3710c5)) * explore routing issues ([0dbbdcf](leather-io@0dbbdcf)) * local copyToClipboard hook ([017fa3a](leather-io@017fa3a)) * psbt stackui layout ([e71e457](leather-io@e71e457))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On the home screen, if I select an inscription for sending under "Collectibles, the active tab inadvertently switches to "Activity" in the background of the appearing modal then switches back to "Balances" once I close the modal, but the screen is now inadvertently scrolled to the very top so I lose my place on the screen:
Screen.Recording.2023-07-19.at.09.49.27.mov
The text was updated successfully, but these errors were encountered: