Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runes] Support runes protocol #4273

Closed
brandonmarshall-tm opened this issue Sep 27, 2023 · 4 comments
Closed

[Runes] Support runes protocol #4273

brandonmarshall-tm opened this issue Sep 27, 2023 · 4 comments
Assignees
Labels
area:bitcoin enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@brandonmarshall-tm
Copy link

Leather doesn't currently support Runes, but it feels like basic support could potentially be offered without a ton of work. Rune transactions are identified with an "R" in the OP_RETURN field. A basic implementation would be to protect any UTXOs containing this "R" designation so they aren't spent with other transactions.

Once the spec is more ironed out, they would be displayed in a similar manner to BRC-20 transactions in Balances.

Here's an example of a Rune transaction:
https://mempool.space/tx/ba8db28ec5aee2804b207c9a6bd95dd41e337fdc1508d977599862fc095b716b

@314159265359879 314159265359879 added Enhancement 💡 enhancement-p4 Non-critical functionality wanted by few users, or there are clear alternatives labels Sep 27, 2023
@markmhendrickson markmhendrickson changed the title Support for Runes Add support for Runes Oct 23, 2023
@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Apr 9, 2024

Our initial support needs:

  • Protection of UTXOs with Runes from missends or misspends during transaction signing generally (in addition to our existing protection for Ordinals and Stamps)
  • Display of Runes balances (in addition to balances for other protocols like Stacks FTs, BRC-20, and SRC-20)

See relevant API docs

@markmhendrickson markmhendrickson added enhancement-p2 Critical functionality needed by few users, with no clear alternatives and removed enhancement-p4 Non-critical functionality wanted by few users, or there are clear alternatives labels Apr 9, 2024
@fbwoolf fbwoolf changed the title Add support for Runes [Runes] Support runes protocol Apr 10, 2024
@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 10, 2024

@alter-eggo made an issue to track your progress here: #5207
Assigned myself to this issue: #5208

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 10, 2024

First PR up here: #5209

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 11, 2024

Going to close this bc we have open issues tracking the actual work here. Linked ^. Balances PR here: #5224

@fbwoolf fbwoolf closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:bitcoin enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Development

No branches or pull requests

6 participants