Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide option to hide values #5096

Closed
BTCAlchemist opened this issue Mar 19, 2024 · 2 comments · Fixed by #5865 · May be fixed by adrianocola/leather-extension#1
Closed

Provide option to hide values #5096

BTCAlchemist opened this issue Mar 19, 2024 · 2 comments · Fixed by #5865 · May be fixed by adrianocola/leather-extension#1
Assignees
@pete-watters
Labels
area:configurations enhancement sprint:2024-09-02 sprint:2024-09-16 sprint:2024-09-23
Milestone
Redesign wallets UX

Comments

@BTCAlchemist
Copy link

When the user clicks the browser extension, the extension shows their account's total USD value. This can be a security issue for users who are in public locations or in a location where they don't want others to see their USD value. Trust Wallet on iOS is a good example where clicking the balance masks all balances as asterisks. Would you please add a feature where the user clicks the USD value to hide/unhide the amounts in the wallet?
@markmhendrickson markmhendrickson added this to the Redesign accounts UX milestone Mar 21, 2024
@markmhendrickson
Copy link
Collaborator

Good idea! We've been discussing this recently as well 🙏

@markmhendrickson markmhendrickson changed the title Hide account values Provide option to hide values Jul 25, 2024
@markmhendrickson markmhendrickson assigned mica000 and unassigned mica000 Jul 25, 2024
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Aug 27, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
f3701e4
This was referenced Aug 30, 2024
Open
Closed
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 2, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
f4f8415
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 2, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
7713135
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 2, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
3cc02b5
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 3, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
57ee6b0
@pete-watters pete-watters linked a pull request Sep 4, 2024 that will close this issue
feat: add option to hide balance, closes leather-io#5096 #5843
Closed
pete-watters pushed a commit to adrianocola/leather-extension that referenced this issue Sep 4, 2024
@adrianocola @pete-watters
feat: add option to hide balance, closes leather-io#5096
dad3fda
pete-watters pushed a commit to adrianocola/leather-extension that referenced this issue Sep 4, 2024
@adrianocola @pete-watters
feat: add option to hide balance, closes leather-io#5096
3078f8f
pete-watters pushed a commit that referenced this issue Sep 4, 2024
@adrianocola @pete-watters
feat: add option to hide balance, closes #5096
07ecad7
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 4, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
78a7805
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 5, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
604cc24
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 9, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
8bc0558
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 9, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
8d4b1cd
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 10, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
ed83a05
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 10, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
c770a25
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 10, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
49e7d00
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 10, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
459f6e5
pete-watters pushed a commit that referenced this issue Sep 11, 2024
@adrianocola @pete-watters
feat: add option to hide balance, closes #5096
cd9192f
adrianocola added a commit to adrianocola/leather-extension that referenced this issue Sep 11, 2024
@adrianocola
feat: add option to hide balance, closes leather-io#5096
d2599ab
pete-watters pushed a commit that referenced this issue Sep 20, 2024
@adrianocola @pete-watters
feat: add option to hide balance, closes #5096
5382134
@markmhendrickson markmhendrickson linked a pull request Sep 20, 2024 that will close this issue
feat: add option to hide balance, closes leather-io#5096 #5865
Merged
pete-watters pushed a commit that referenced this issue Sep 20, 2024
@adrianocola @pete-watters
feat: add option to hide balance, closes #5096
62061f9
pete-watters pushed a commit that referenced this issue Sep 24, 2024
@adrianocola @pete-watters
feat: add option to hide balance, closes #5096
66aa61d
github-merge-queue bot pushed a commit that referenced this issue Sep 24, 2024
@adrianocola @pete-watters
feat: add option to hide balance, closes #5096
32b064f
@pete-watters
Copy link
Contributor

A contributor has implemented this feature and it will be available in the next release.

Thanks again @adrianocola 👏

alexp3y pushed a commit that referenced this issue Sep 25, 2024
@adrianocola @alexp3y
feat: add option to hide balance, closes #5096
7da2f05
kyranjamie pushed a commit that referenced this issue Oct 7, 2024
@semantic-release-bot
chore(release): 6.48.0
24425d1 
## [6.48.0](v6.47.1...v6.48.0) (2024-10-07)

### Features

* add inscription send flow testing, closes leather-io/issues[#191](#191) ([54fce3e](54fce3e))
* add option to hide balance, closes leather-io[#5096](#5096) ([32b064f](32b064f))
* bitflow implemenation, closes leather-io/issues[#99](#99) ([9c0a6e8](9c0a6e8))
* redesign connection flow, closes leather.io/issues[#283](#283) ([0717b12](0717b12))

### Bug Fixes

* **analytics:** initial route only used in report analytics ([a253390](a253390))
* broken styles ([cc6edb5](cc6edb5))
* edit network urls, closes leather-io/extension[#5795](#5795) ([7256379](7256379))
* path-to-regexp vulnerability GHSA-9wv6-86v2-598j ([36a84dc](36a84dc))
* refactor add network to use card footer, closes leather-io/issues[#313](#313) ([68de602](68de602))
* secret key stored cleartext in memory ([e0bdec9](e0bdec9))
* security audit failures ([d4c8b48](d4c8b48))
* show transaction amount above Increase Fee, closes [#5826](#5826) ([0a61651](0a61651))
* storybook icons, closes leather-io/issues[#294](#294) ([a0b30eb](a0b30eb))
* update manifest description, closes leather-io/issues[#310](#310) ([3450e0a](3450e0a))

### Internal

* blockchain model ([6bbb1fa](6bbb1fa))
* currency model imports ([54e2865](54e2865))
* pin node < v22 ([27f3b67](27f3b67))
* post-release merge back ([2b6bc91](2b6bc91))
* remove brc20 send flow code ([ad2d69f](ad2d69f))
* update wbip004 method name, closes [#5866](#5866) ([d0873e8](d0873e8))
* update webpack ([da58aa7](da58aa7))
* upgrade pnpm ([fb5a46f](fb5a46f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:configurations enhancement sprint:2024-09-02 sprint:2024-09-16 sprint:2024-09-23
Projects
None yet
Milestone
Redesign wallets UX
4 participants
@markmhendrickson @pete-watters @BTCAlchemist @mica000