Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit total balance to include more tokens and token order #5159

Open
fbwoolf opened this issue Apr 3, 2024 · 3 comments
Open

Revisit total balance to include more tokens and token order #5159

fbwoolf opened this issue Apr 3, 2024 · 3 comments
Assignees
Labels
effort:medium Expected to take 2-5 days of integration work enhancement

Comments

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 3, 2024

As we start to add more fiat values to our assets list, we need to revisit how our code is setup to add new token values to our total fiat balance shown in the account header.

As part of this work, we should look at refactoring how we handle metadata for Stacks FTs. It was requested that the balances be in descending fiat balance order, but with how we handle balances and fiat prices (market data), it is difficult to do this with a larger refactor.

See comments on this issue for ref: #5151 (comment)

@markmhendrickson markmhendrickson added this to the Redesign tokens UX milestone Apr 4, 2024
@fbwoolf fbwoolf changed the title Revisit total balance to include more tokens Revisit total balance to include more tokens and token order Apr 4, 2024
@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 21, 2024

@markmhendrickson it might be that we want to prioritize this refactoring now that we have move fiat values getting pushed?

@fbwoolf fbwoolf self-assigned this Apr 21, 2024
@fbwoolf fbwoolf added the effort:medium Expected to take 2-5 days of integration work label Apr 21, 2024
@kyranjamie
Copy link
Collaborator

+1.

How we read balance data in general needs a refactor. Suggest the solution to this considers how we can first collect all relevant data, then render the UI, rather than individual components fetching their own data.

We also need to be very alert caching/request efficiency in solving this.

@markmhendrickson
Copy link
Collaborator

Yep agreed on making this a priority. @fbwoolf thanks for taking it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:medium Expected to take 2-5 days of integration work enhancement
Projects
None yet
Development

No branches or pull requests

3 participants