Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users can't connect to dapp or it takes forever #5509

Closed
314159265359879 opened this issue Jun 8, 2024 · 11 comments · Fixed by #5636
Closed

Users can't connect to dapp or it takes forever #5509

314159265359879 opened this issue Jun 8, 2024 · 11 comments · Fixed by #5636
Assignees
@314159265359879
Labels
area:api area:testnet area:throttling bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds

Comments

@314159265359879
Copy link
Contributor

This issue is unresolved
#5021

I see these errors but I am not sure if they are related. It his happening on all dapps. When account data isn't fully loaded yet. It takes forever even when the balance is loaded. This happening especially in wallets with 20 or more accounts and when for example the account balance is still being loaded. I have also seen the same issue (connection to dapp doesn't complete) when balance was just loaded.

Steps to reproduce
0. Restore Leather with an existing Secret Key that has 20 or more accounts in it.

  1. Click connect on app.alexlab.co
    or stacks.gamma.io
    or any other dapp
  2. Scroll down until you see all the "loading" animations for balance
  3. Click one of the accounts with the accounts to connect
  4. spinning (to connect) starts and never stops... dapps never connects
    image

Possibly unrelated console errors
image

Workarounds

  • Wait longer for the balances in the "select account" screen to load (works most of the time)
  • Click additional times (sometimes works)
@314159265359879 314159265359879 added bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds labels Jun 8, 2024
@314159265359879
Copy link
Contributor Author

314159265359879 commented Jun 10, 2024 •
edited
Loading

It looks like users can't switch to different accounts within Leather either because there is loading or throttling going on.

In the above example the wallet is stuck when scrolling over to connect to a specific account on a dapp.

The video displays another issue, that is reproducible with these steps:

  1. being on the last account in a wallet, something in the 400 range
  2. Scrolling all the way up to account 1 (why is there no scroll bar?)
  3. Selecting account 1, clicking it a couple times in the hope of working around the issue... doesn't work
  4. click outside the wallet so the modal closes
  5. try to open it again... doesn't work
  6. Here the extension icon in the browser is clicked and nothing happens (Brave, wallet version 6.42.0):
2024-06-10_23-53-21.mp4

@314159265359879 314159265359879 mentioned this issue Jun 17, 2024
Open
@markmhendrickson
Copy link
Collaborator

@alter-eggo this is quite high priority and presumably related to client-side throttling?

@alter-eggo
Copy link
Contributor

@markmhendrickson yes, seems so, will take a look

alter-eggo added a commit that referenced this issue Jul 5, 2024
@alter-eggo
fix: choose account prevent bug, closes #5509
041edfa
alter-eggo added a commit that referenced this issue Jul 8, 2024
@alter-eggo
fix: choose account prevent bug, closes #5509
3b2f977
alter-eggo added a commit that referenced this issue Jul 8, 2024
@alter-eggo
fix: choose account prevent bug, closes #5509
d1c440e
alter-eggo added a commit that referenced this issue Jul 9, 2024
@alter-eggo
fix: choose account prevent bug, closes #5509
9c769ed
github-merge-queue bot pushed a commit that referenced this issue Jul 10, 2024
@alter-eggo
fix: choose account prevent bug, closes #5509
89500a8
@pete-watters pete-watters mentioned this issue Jul 10, 2024
Merged
@314159265359879
Copy link
Contributor Author

Confirmed fixed in this PR #5636

@markmhendrickson markmhendrickson linked a pull request Jul 12, 2024 that will close this issue
release: unkempt-turtle #5636
Merged
kyranjamie pushed a commit that referenced this issue Jul 15, 2024
@semantic-release-bot
chore(release): 6.43.0
cfa8191 
## [6.43.0](v6.42.2...v6.43.0) (2024-07-15)

### Features

* add Leather to WBIP004 array, closes [#5615](#5615) ([e38f6ab](e38f6ab))
* mock mainnet btc blockstream requests ([16d751c](16d751c))

### Bug Fixes

* choose account prevent bug, closes [#5509](#5509) ([89500a8](89500a8))
* collectible hover, closes [#4971](#4971) ([7728eeb](7728eeb))
* confine clickable area of account switcher to account name and chevron, closes [#5621](#5621) ([472c7e4](472c7e4))
* dust change amounts, closes [#4979](#4979) ([8b40ea7](8b40ea7))
* increase zIndex of tooltip to prevent it being obscured, closes [#5622](#5622) ([a1f86bb](a1f86bb))
* show account name in signPsbt and signBip322 header, ref [#4657](#4657) [#4859](#4859) ([71f2565](71f2565))

### Internal

* add new analytics events ([3f9548e](3f9548e))
* post-release merge back ([c1bbf89](c1bbf89))
* reenable swaps, closes leather-io/issues[#98](#98) ([5faba22](5faba22))
@314159265359879
Copy link
Contributor Author

314159265359879 commented Jul 23, 2024 •
edited
Loading

I see this issue again testing a testnet app
in the list of accounts to connect with, I click an account and the loading spinner keeps spinning for a minute (perhaps longer) before actually proceeding to connect.

On mainnet it is quicker

@markmhendrickson
Copy link
Collaborator

@alter-eggo any idea why it may be slower on testnet vs. mainnet given your work on this issue?

@alter-eggo
Copy link
Contributor

hm, we have quite tight limiting rule on testnet, I'll fix it

@markmhendrickson markmhendrickson changed the title Users can't connect to dapp or it takes forever Users can't connect to dapp or it takes forever (on testnet) Jul 25, 2024
@markmhendrickson
Copy link
Collaborator

@314159265359879 to confirm if still an issue in prod

@314159265359879 314159265359879 changed the title Users can't connect to dapp or it takes forever (on testnet) Users can't connect to dapp or it takes forever Aug 1, 2024
@314159265359879
Copy link
Contributor Author

314159265359879 commented Aug 1, 2024 •
edited
Loading

I am def. seeing this again now I saw it connecting to stacks.gamma.io, connecting to renewbns.com and connecting to this https://hozzjss.github.io/stacks-ogs/friedger on mainnet.

Here are some of the console errors
image

image

The errors could be just this last site. On gamma I only see these
image

I have not been able to test this with the 1.2 sec build.

@markmhendrickson
Copy link
Collaborator

@314159265359879 want to test this again with #5726 once #5690 is merged into that release?

@314159265359879
Copy link
Contributor Author

It looks better now with 6.45.2 and those PR's included.

This was referenced Oct 23, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@314159265359879 314159265359879

Labels
area:api area:testnet area:throttling bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release: unkempt-turtle leather-io/extension
3 participants
@markmhendrickson @314159265359879 @alter-eggo