Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix alignment of page header logo and menu #5802

Closed
pete-watters opened this issue Aug 22, 2024 · 6 comments · Fixed by #5801, leather-io/mono#406 or #5823
Closed

bug: fix alignment of page header logo and menu #5802

pete-watters opened this issue Aug 22, 2024 · 6 comments · Fixed by #5801, leather-io/mono#406 or #5823
Assignees
@pete-watters
Labels
effort:small Expected to take up to 1 day of integration work needs:visual-improvement sprint:2024-08-26
Milestone
Fix urgent bugs

Comments

@pete-watters
Copy link
Contributor

There are some visual issues regarding alignment of page headers we need to address. Reported by @fbwoolfhere

I have some Q's about how things should line up here: https://trustmachines.slack.com/archives/C05LRS7G44R/p1724305603462199
@pete-watters pete-watters added bug-p4 Non-critical functionality broken for few users, or there are clear workarounds needs:visual-improvement labels Aug 22, 2024
@pete-watters pete-watters self-assigned this Aug 22, 2024
@pete-watters pete-watters added this to the Fix urgent bugs milestone Aug 22, 2024
@pete-watters pete-watters linked a pull request Aug 22, 2024 that will close this issue
fix: fix issues with alignment of page headers #5801
Merged
@pete-watters
Copy link
Contributor Author

We have a few types of header and I want to make sure each one is exactly correct:

onboarding-headers.mp4

Screenshot 2024-08-22 at 07 07 41

page-header.mp4
home-header.mp4

@pete-watters pete-watters mentioned this issue Aug 22, 2024
Merged
@pete-watters pete-watters reopened this Aug 23, 2024
@pete-watters
Copy link
Contributor Author

@mica000 kindly came back to me with some precise details on this. I will spend a bit more time on it making it perfect.

Ideally I will also then spend time adding visual tests

@markmhendrickson markmhendrickson removed the bug-p4 Non-critical functionality broken for few users, or there are clear workarounds label Aug 26, 2024
@mica000
Copy link

mica000 commented Aug 26, 2024

Review here: https://trustmachines.slack.com/archives/C05LRS7G44R/p1724346724812739?thread_ts=1724305603.462199&cid=C05LRS7G44R

@pete-watters pete-watters added the effort:small Expected to take up to 1 day of integration work label Aug 26, 2024
@pete-watters pete-watters mentioned this issue Aug 27, 2024
Closed
@pete-watters
Copy link
Contributor Author

As part of this task I need to add some more integration tests for header items and also to capture BRC-20 on Ledger as oer #5797 (comment)

@pete-watters pete-watters mentioned this issue Aug 29, 2024
Open
pete-watters added a commit that referenced this issue Aug 29, 2024
@pete-watters
chore: fix padding of asset list items in activity, ref #5802
229ce06
pete-watters added a commit that referenced this issue Aug 29, 2024
@pete-watters
fix: update padding of onboarding header to align buttons, ref #5802
d746f00
pete-watters added a commit that referenced this issue Aug 29, 2024
@pete-watters
fix: remove px for all page headers, ref #5802
ba20d88
pete-watters added a commit that referenced this issue Aug 29, 2024
@pete-watters
fix: remove px for all page headers above sm, ref #5802
6867e20
pete-watters added a commit that referenced this issue Aug 29, 2024
@pete-watters
fix: only show Send title above small view, ref #5802
b3e5ae7
pete-watters added a commit that referenced this issue Aug 29, 2024
@pete-watters
fix: update padding of onboarding header to align buttons, ref #5802
c5dc573
pete-watters added a commit that referenced this issue Aug 29, 2024
@pete-watters
fix: remove px for all page headers above sm, ref #5802
255283c
pete-watters added a commit that referenced this issue Aug 29, 2024
@pete-watters
fix: only show Send title above small view, ref #5802
de3bb0e
pete-watters added a commit to leather-io/mono that referenced this issue Aug 30, 2024
@pete-watters
fix: adjust BigTitle padding and close, ref leather-io/extension#5802
104b0a3
pete-watters added a commit to leather-io/mono that referenced this issue Aug 30, 2024
@pete-watters
fix: adjust BigTitle padding and close, ref leather-io/extension#5802
fe407d7
@pete-watters
Copy link
Contributor Author

Opened this PR to fix issues with the BigTitle header

pete-watters added a commit to leather-io/mono that referenced this issue Aug 30, 2024
@pete-watters
fix: adjust BigTitle padding and close, ref leather-io/extension#5802
20d54b5
This was linked to pull requests Aug 30, 2024
fix: adjust BigTitle padding and close, ref leather-io/extension#5802 leather-io/mono#406
Merged
chore: header alignment #5823
Merged
github-merge-queue bot pushed a commit to leather-io/mono that referenced this issue Aug 30, 2024
@pete-watters
fix: adjust BigTitle padding and close, ref leather-io/extension#5802
169fdc4
@pete-watters pete-watters reopened this Aug 30, 2024
pete-watters added a commit that referenced this issue Aug 30, 2024
@pete-watters
fix: adjust BigTitle padding and close, ref #5802
332e09e
@pete-watters pete-watters mentioned this issue Aug 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@pete-watters
chore: fix padding of asset list items in activity, ref #5802
3e4d8a2
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@pete-watters
fix: update padding of onboarding header to align buttons, ref #5802
203629d
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@pete-watters
fix: remove px for all page headers above sm, ref #5802
dae0f47
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@pete-watters
fix: only show Send title above small view, ref #5802
f45fedf
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@pete-watters
fix: adjust BigTitle padding and close, ref #5802
6b9566a
@pete-watters pete-watters mentioned this issue Sep 3, 2024
Merged
@pete-watters
Copy link
Contributor Author

Released in #5838

kyranjamie pushed a commit that referenced this issue Sep 3, 2024
@semantic-release-bot
chore(release): 6.47.1
aa8ffe8 
## [6.47.1](v6.47.0...v6.47.1) (2024-09-03)

### Bug Fixes

* adjust BigTitle padding and close, ref leather-io/extension[#5802](#5802) ([6b9566a](6b9566a))
* don't show send in header ([d8ed76a](d8ed76a))
* only show Send title above small view, ref [#5802](#5802) ([f45fedf](f45fedf))
* remove px for all page headers above sm, ref [#5802](#5802) ([dae0f47](dae0f47))
* send inscription formatting and InfoCardButton icon colour, ref leather-io/extension[#5828](#5828) ([afc50d5](afc50d5))
* update padding of onboarding header to align buttons, ref [#5802](#5802) ([203629d](203629d))

### Internal

* fix padding of asset list items in activity, ref [#5802](#5802) ([3e4d8a2](3e4d8a2))
* improve open API and add tests, ref leather-io/issues[#5800](#5800) ([9d52d9e](9d52d9e))
* post-release merge back ([e554376](e554376))
* update link to docs on open, ref [#5800](#5800) ([003a6ad](003a6ad))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
effort:small Expected to take up to 1 day of integration work needs:visual-improvement sprint:2024-08-26
Projects
None yet
Milestone
Fix urgent bugs
3 participants
@markmhendrickson @pete-watters @mica000