Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for custom serveo ssh port #4

Closed
wants to merge 1 commit into from
Closed

feat: added support for custom serveo ssh port #4

wants to merge 1 commit into from

Conversation

sahilanguralla
Copy link

@sahilanguralla sahilanguralla commented Nov 9, 2019 •
edited
Loading

This PR includes added support to mention custom SSH port incase the custom serveo instance is running on a port other than default SSH port, which is 22. Fixes #3

@sahilanguralla
Copy link
Author

@lechup it would be great if this PR gets reviewed soon. Thanks. 🙂

@lechup
Copy link
Owner

lechup commented Nov 16, 2019

@sahilanguralla I've merged older PR so this one needs update, are You able to do it? Ouh, and please create one commit if possible with all changes :)

@lechup lechup mentioned this pull request Nov 16, 2019
Open
@sahilanguralla
Copy link
Author

@sahilanguralla I've merged older PR so this one needs update, are You able to do it? Ouh, and please create one commit if possible with all changes :)

@lechup done. Please review.

@lechup lechup mentioned this pull request Nov 20, 2019
Open
@lechup
Copy link
Owner

lechup commented Nov 20, 2019

@sahilanguralla I've created PR based on Your work #6 , I've added some cleanup in the code, please check if it works for You, if You want You can update Your PR the same way and I'll merge Your version not mine, thanks!

@sahilanguralla
Copy link
Author

@sahilanguralla I've created PR based on Your work #6 , I've added some cleanup in the code, please check if it works for You, if You want You can update Your PR the same way and I'll merge Your version not mine, thanks!

I have one doubt regarding making the ssh_port non-optional. I have commented in your PR.

@sahilanguralla sahilanguralla closed this by deleting the head repository Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue if custom server not running at port 22
2 participants
@sahilanguralla @lechup