Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m4a audio files issue #106

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

m4a audio files issue #106

wants to merge 4 commits into from

Conversation

oeuillot
Copy link

  • Try to fix issue with some m4a files whose never call the return callback
  • fileSize callback function takes an error for the first parameter because we can not use throw exception in this context.

@oeuillot
fileSize callback function takes an error for the first parameter
f71402b 
We can not use throw Exception here
@oeuillot
- Try to fix issue with some m4a which never call the return callback
a64b8a4 
- fileSize callback function takes an error for the first parameter
because we can not use throw exception in this context.
@leetreveil
Copy link
Owner

Looks like the style needs fixing first:

https://travis-ci.org/leetreveil/musicmetadata/jobs/98523140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oeuillot @leetreveil