New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leftwm-theme should throw an error if the prebuilt themes aren't available for copying #62

Open

mautamu opened this issue Dec 22, 2022 · 1 comment

Labels

good first issue help wanted

Member

mautamu commented Dec 22, 2022

leftwm-theme/src/operations/new.rs

Line 72 in 22b537b

"0" => copy_files("/usr/share/leftwm/themes/basic_lemonbar/", &dir),

introduces an error where someone can create a new theme as a fork of a basic template but not see an error.

mautamu added good first issue help wanted labels

Member Author

mautamu commented Dec 22, 2022

Repro:

install leftwm and leftwm-theme
remove (or don't install) the prebuilt themes to /usr/share/leftwm/themes/
create a theme patterned after one of the basics, e.g. polybar
see bug

US: As a user, I want to see only the theme templates which are available to be cloned so that I can build my own themes quickly and easily.

Acceptance criteria:

Only themes which are installed to /usr/share/leftwm/themes/ are provided as options.
Attempting to select other themes is not possible and/or throws a clear error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment