Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Only entity labels are considered for filters #350

Closed
strawgate opened this issue Aug 27, 2024 · 3 comments · Fixed by #428
Closed

[2.0] Only entity labels are considered for filters #350

strawgate opened this issue Aug 27, 2024 · 3 comments · Fixed by #428

Comments

@strawgate
Copy link
Collaborator

Should we also check device labels for inclusion/exclusion of labels?

@legrego
Copy link
Owner

legrego commented Sep 8, 2024

Yeah, this makes a lot of sense to me. Some devices can have many entities, so at times it's easier from an administrative perspective to "just" configure the device, and let the entities respect the device configuration.

@strawgate
Copy link
Collaborator Author

Would we consider this a breaking change and I should land this in 2.0?

@legrego
Copy link
Owner

legrego commented Nov 18, 2024

@strawgate I suppose we should consider this breaking, so landing this in 2.0 makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants