Disuse deprecated pkg_resources module #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support distributing our default template as package data. (See ticket lektor#5.)
dairiki
force-pushed
the
fix.5-default-template
branch
from
b9e6360
to
6c6bbee
Compare
Switch from using `pkg_resources` to `importlib.resources` for accessing package data.
The `tag.html` template (which is identical in content to `lektor_tags_default_template.html`) appears to be unused.
dairiki
force-pushed
the
fix.5-default-template
branch
from
6c6bbee
to
093a2cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set out to remove the usage of
pkg_resourceswhich is now deprecated in favor ofimportlib(see here).Lektor-tagsusespkg_resourcesto find where it default Jinja template is installed. This led me to discover that, as things are currently, the default template is not installed at all (at least whenlektor-tagsis installed from a wheel)! (See #5).So this PR first fixes #5, then removes the usage of
pkg_resourcesin favor ofimportlib.resources.Fixes #5