Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compatibility with PHP >= 7.2 #2

Open
fteuber opened this issue Jan 30, 2020 · 1 comment
Open

compatibility with PHP >= 7.2 #2

fteuber opened this issue Jan 30, 2020 · 1 comment

Comments

@fteuber
Copy link

fteuber commented Jan 30, 2020

Hi,
with PHP 7.2 the code in CaptchaService throws warnings when evaluating count($this->captchaSession->getCaptchaKey()) == NULL as count() only accept arrays / countable as argument anymore. I "fixed" it by instead using empty($this->captchaSession->getCaptchaKey()) but I really don't understand this part.

I could provide a PR but am unsure if this code could instead just be deleted?
@pankajlele
Copy link
Member

Hi! @fteuber
Thank you for your message. Yes please send PR to remove the count() part. it is not needed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pankajlele @fteuber