Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment region doesn't work on vi-mode #1166

Closed
Sasanidas opened this issue Nov 27, 2023 · 4 comments
Closed

Comment region doesn't work on vi-mode #1166

Sasanidas opened this issue Nov 27, 2023 · 4 comments

Comments

@Sasanidas
Copy link
Member

I think the command comment-region doesn't work using vi-mode

comment_region.mp4
@swapneils
Copy link

swapneils commented Dec 6, 2023

This isn't about comment-region specifically. The vi-mode visual state isn't being accounted for in region-based commands like lisp-eval-region; if you use mark-set to select text then region commands (including comment-or-uncomment-region) work as expected.

@Sasanidas
Copy link
Member Author

Sasanidas commented Dec 6, 2023

I'm fully aware of that, I was just point it out the issue (in this case regarding the comment region).

@Sasanidas
Copy link
Member Author

I propose a solution for it, #1176

@gagero
Copy link

gagero commented Mar 13, 2024

Since that's been merged, shouldn't this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants