Fix and refactor kill whole line #1642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update point after backspacing and yanking while isearch is active | ;; one test is what you need (| is the point) with this patch, if you search for "ee" and then backspace, the point will move to the end of the word "one". in Lem currently, if you search for "ee" and then backspace, the point will stay after "ee", when I feel it should be at the end of "one" since the search string has changed. this patch also works when reverse searching | ;; one test is what you need (| is the point) with this patch, if "one test" is the current kill string and you yank, the point will move to after "one test". in Lem currently, the point will not move after yanking, which i don't think is natural
…ghting`. the keybinds feel very natural, and having the command available to the user as a default keybind seems user-friendly to me. i apologize for not knowing git and if this creates conflicts in case you don't accept my previous pull requests involving updating the point during isearch on backspace and yank. i'm a pure beginner with git, but i will continue to get better at it
…ete-previous-char`, which seems wrong. this patch makes `kill-whole-line`, one, kill the entire line, including the new line at the end of a line if indeed there is one, and, two, allow it to be prefixed. |;; one one one ;; two two two ;; three three three ;; four four four ;; five five five (| is point) if `5 kill-whole-line`, all lines are deleted. ;; one one one ;; two two two ;; three three |three ;; four four four ;; five five five (| is point) if `0 kill-whole-line`, nothing happens. ;; one one one ;; two two two ;; three three |three ;; four four four ;; five five five (| is point) if `-2 kill-whole-line`, ";; one one one" and ";; two two two" are deleted, and the point stays right before the last "three". if you want to delete the previous "three"s, then you can use the `kill` command. i'm curious if others agree with me
|
going to close this one, and make another one. my code feels wrong, but i hope you'll have patience with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry, again, about all the github trouble. i'll study git in the next days so that my requests are not redundant.
at present, Lem's
kill-whole-linekills the line and then doesdelete-previous-char, which seems wrong. this patch makeskill-whole-line, one, kill the entire line, including the new line at the end of a line if indeed there is one, and, two, allow it to be prefixed.|;; one one one
;; two two two
;; three three three
;; four four four
;; five five five
(| is point) if
5 kill-whole-line, all lines are deleted.;; one one one
;; two two two
;; three three |three
;; four four four
;; five five five
(| is point) if
0 kill-whole-line, nothing happens.;; one one one
;; two two two
;; three three |three
;; four four four
;; five five five
(| is point) if
-2 kill-whole-line, ";; one one one" and ";; two two two" are deleted, and the point stays right before the last "three". if you want to delete the previous "three"s, then you can use thekillcommand.i'm curious if others agree with me