Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta page - better iframe sizing #27

Open
lemeryfertitta opened this issue Jan 31, 2024 · 3 comments
Open

Beta page - better iframe sizing #27

lemeryfertitta opened this issue Jan 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@lemeryfertitta
Copy link
Owner

Some widths and heights of the embedded instagram videos are a bit awkward to view, either on desktop, mobile, or both. Its possible that getting the post metadata could allow for better sizing, though my initial look into this wasn't very fruitful.

@lemeryfertitta lemeryfertitta added the enhancement New feature or request label Jan 31, 2024
@gardaholm
Copy link
Contributor

gardaholm commented Feb 14, 2024

The Left / Right icons are a bit off compared to the result page, at least on my screens (mobile + desktop). Maybe this can be adressed too in with this issue.

@lemeryfertitta
Copy link
Owner Author

Good catch, I fixed those though its probably not worth a deploy, will just catch it in the next deploy.

The iframe sizing is a little trickier. I'm not even sure its possible to make it consistent since instagram has a whole bunch of different sizes that it gives you. The apps don't even bother with embedding and just send you to instagram, but I like the idea of embedding, I feel like it makes it a bit smoother to navigate.

@gardaholm
Copy link
Contributor

I think it's ok as it is, it differs depending on the video sizes and if it was posted as video only or video in a slideshow.

Overall its still easy to use and better to scroll throw the beta videos than using the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants