Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Timestamp #89

Closed
ItsDang opened this issue Sep 2, 2024 · 6 comments
Closed

Log Timestamp #89

ItsDang opened this issue Sep 2, 2024 · 6 comments
Assignees

Comments

@ItsDang
Copy link
Contributor

ItsDang commented Sep 2, 2024

With the addition of logging sends in #72, I noticed that everything is being set to the current UTC day at midnight. From my limited testing, it looks like the times showing in the official app stored/display in EDT/EST? What time does it show for other users? I switch the TZ around on my phone but the time displayed remained the same in the app.
If so send current Eastern time in log ascent.

@gardaholm
Copy link
Contributor

I just added date for the logging in the first release, and didn't care about the time.
But this can be added pretty easily …

@lemeryfertitta
Copy link
Owner

Thanks for the report and PR, merged in the fix. Will deploy with the mirror changes once those are in

@lemeryfertitta
Copy link
Owner

Deployed

@gardaholm
Copy link
Contributor

@ItsDang did the Timestamp work for your timezone?
I logged a route with climbdex today at 08:00 local time in Vienna (should be 06:00 GMT).
When I checked the entry in the aurora app I saw 01:00. So I think the timestamps are (still) off.

When I check my Logbook export (or in the aurora app) the timestamps are shown in my local timezone, at least it looks like, because I did the boulders in the evening.
image

but didnt spent much time checking this, just realized it when I controlled the tick of the mirrored route today …

@ItsDang
Copy link
Contributor Author

ItsDang commented Sep 9, 2024

@gardaholm Hmm, yeah it "works" for me because it's set to EST, { timeZone: 'America/New_York'}, I think this needs to be removed and it should work for you too. Since the timezone isn't being stored, just storing local time seems best. I'll commit the change later today.

@lemeryfertitta
Copy link
Owner

Fix should be deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants