Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #62: Alert message on API error #65

Merged
merged 10 commits into from
May 13, 2024
Merged

Issue #62: Alert message on API error #65

merged 10 commits into from
May 13, 2024

Conversation

brmnjsh
Copy link

@brmnjsh brmnjsh commented May 3, 2024 •
edited
Loading

Issue

@brmnjsh brmnjsh changed the title 62 toast message on error Issue #62: Toast message on error May 3, 2024
@brmnjsh brmnjsh mentioned this pull request May 3, 2024
Closed
@brmnjsh brmnjsh changed the title Issue #62: Toast message on error Issue #62: Toast message on API error May 3, 2024
lemeryfertitta
lemeryfertitta requested changes May 3, 2024
View reviewed changes
Copy link
Owner

@lemeryfertitta lemeryfertitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool, thanks for the contribution! Just two small suggestions, one about the UI and one about the code.

climbdex/api.py Outdated Show resolved Hide resolved
climbdex/templates/climbCreation.html.j2 Outdated Show resolved Hide resolved
brmnjsh
brmnjsh commented May 5, 2024
View reviewed changes
climbdex/static/js/results.js Outdated Show resolved Hide resolved
brmnjsh
brmnjsh commented May 5, 2024
View reviewed changes
climbdex/api.py Show resolved Hide resolved
@brmnjsh brmnjsh requested a review from lemeryfertitta May 5, 2024 03:11
@brmnjsh brmnjsh changed the title Issue #62: Toast message on API error Issue #62: Alert message on API error May 6, 2024
brmnjsh
brmnjsh commented May 6, 2024
View reviewed changes
climbdex/api.py Show resolved Hide resolved
lemeryfertitta
lemeryfertitta requested changes May 6, 2024
View reviewed changes
Copy link
Owner

@lemeryfertitta lemeryfertitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates - just one comment to resolve and then I'll merge this in and get both of your PRs deployed!

climbdex/api.py Show resolved Hide resolved
climbdex/static/js/results.js Outdated Show resolved Hide resolved
climbdex/api.py Show resolved Hide resolved
@lemeryfertitta lemeryfertitta mentioned this pull request May 6, 2024
Open
@brmnjsh brmnjsh requested a review from lemeryfertitta May 7, 2024 19:25
@brmnjsh
Copy link
Author

brmnjsh commented May 7, 2024 •
edited
Loading

@lemeryfertitta ok, I added the location.search back. Should be g2g now!

lemeryfertitta
lemeryfertitta approved these changes May 13, 2024
View reviewed changes
Copy link
Owner

@lemeryfertitta lemeryfertitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lemeryfertitta lemeryfertitta merged commit 55c37a3 into lemeryfertitta:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemeryfertitta lemeryfertitta lemeryfertitta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brmnjsh @lemeryfertitta