Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First download from extension button not added #93

Open
chaotic-dev opened this issue Apr 22, 2022 · 3 comments · May be fixed by #94
Open

First download from extension button not added #93

chaotic-dev opened this issue Apr 22, 2022 · 3 comments · May be fixed by #94

Comments

@chaotic-dev
Copy link

chaotic-dev commented Apr 22, 2022

Clicking the Omina button on the extension launches the application but doesn't add the download until clicked a second time

Expected behavior: Omina should be launched and the post should be added according to download settings

Pixiv Toolkit Version: v5.5.3
Pixiv Omina Version: 0.9.1 (16ae0bc)
Operating System: Pop!_OS 21.10 (Issue should be OS independent as far as I can tell)
Browser: Mozilla Firefox for Ubuntu 99.0 (64-bit)

@chaotic-dev chaotic-dev linked a pull request Apr 22, 2022 that will close this issue
@sakkamade
Copy link
Contributor

sakkamade commented May 26, 2022

Sorry, no idea what #94 PR really does, but I just tried and button works fine for me even without that patch.

I only had to add a new XDG mime scheme, like:

$ xdg-mime default *desktop-filename*.desktop x-scheme-handler/pixiv-omina

Or manually edit mimeapps file:

~/.config/mimeapps.list
---
...
[Default Applications]
...
x-scheme-handler/pixiv-omina=*desktop-filename*.desktop

Oh, and I have a .desktop file that executes Pixiv Omina Appimage and passes arguments to it with something like %U:

~/.local/share/applications/pixiv-omina.desktop
---
...
Exec=/path/to/appimage %U
...

But I guess any of the following would work %f, %u, %F, %U.

@chaotic-dev
Copy link
Author

I've set up the xdg-mime and created a .desktop entry as well. My issue was that if Omina isn't currently running, the first time you click download it will only open the app but won't download the file. It looks like the arguments aren't being read during the first launch.

@sakkamade
Copy link
Contributor

Ah, you are completely right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants