Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goal does not seem to catch jstl errors #137

Open
goodale opened this issue Feb 9, 2023 · 2 comments
Open

goal does not seem to catch jstl errors #137

goodale opened this issue Feb 9, 2023 · 2 comments

Comments

@goodale
Copy link
Contributor

goodale commented Feb 9, 2023

I would expect the jspc compile to catch the following invalid property error and cause the compile goal to fail

<c:if test="${not empty data.expiration}">
                                            (Expires: ${data.expirations})</c:if>

In the above example the data.expirations property does not exist in the object data. e.g. getExpiration() is valid. But the method/property .getExpirations() does not exist and should fail the build. We're looking for a way to ensure the build fails if there's such a typo.

After updating to the latest 3.x version of jspc-maven-plugin we're finding that a build with the above error still succeeds.

@leonardehrenfried
Copy link
Owner

Have you tried with the latest version 4.1.0.

I must admit that I haven't touched JSPs in over ten years so I have no idea if that is according to the spec or not.

I'm not going to investigate this problem but if you have a PR that fixes it, I'm happy to merge it in.

@goodale
Copy link
Contributor Author

goodale commented Feb 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants