Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support m2e/Eclipse integration #25

Open
candrews opened this issue May 21, 2018 · 3 comments
Open

Support m2e/Eclipse integration #25

candrews opened this issue May 21, 2018 · 3 comments

Comments

@candrews
Copy link

It would be nice if jspc-maven-plugin included m2e support.

See https://wiki.eclipse.org/M2E_compatible_maven_plugins

Adding such support would eliminate having to manually add m2e configuration to the pom for every project that uses jspc-maven-plugin and would speed up development by only causing Eclipse to refresh files that are changed by the plugin.

@leonardehrenfried
Copy link
Owner

Sounds like an interesting addition.

Unfortuntely I have no idea how to do this.

If you send a pull request with this functionality, I'd gladly merge it in.

@tcollignon
Copy link
Collaborator

Hi @candrews
Thx for sharing your mind
I'm using this plugin a lot in my current projects, but I don't see your use cases, can you explain more please?

In my case, the jspc-maven-plugin is using in CI, to ensure they are not jspc error, and package all jspc in final WAR. But in development i'm not using it, because Tomcat Handle it directly. So I never tell to eclipse to run this plugin. Maybe you have different cases

Other thing : you need m2e to "execute" the plugin or to "ignore" the plugin? I think it's execute, but I ask. And you need incremental using too ? Because if it's true, they are some work to do in jspc-maven-plugin, because we need to add BuildContext support directly in the code.

Regards

@candrews
Copy link
Author

I'm also using this plugin as a key part of the CI strategy. However, I'm finding it useful for developers, and I think having it be able to report errors in Eclipse (ex, when a change is made to a JSP that is invalid then having it report that error in Eclipse's "Problems" view, just like if an illegal change is made to Java source code) would be really great.

Ideally, incremental would be supported, which would require changes to jspc-maven-plugin. I haven't dug in to see how exactly to do it, but using BuildContext as described at https://wiki.eclipse.org/M2E_compatible_maven_plugins shouldn't be too bad, I hope!

candrews added a commit to candrews/jspc-maven-plugin that referenced this issue Jun 1, 2018
Support incremental builds as well as Eclipse compatible error reporting

See https://wiki.eclipse.org/M2E_compatible_maven_plugins

Closes: leonardehrenfried#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants