clean spectator

leonitousconforti · Sep 19, 2023 · 86f0120 · 86f0120
1 parent 3a52c68
commit 86f0120
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/spectator/src/components/WebRtcView.tsx b/packages/spectator/src/components/WebRtcView.tsx
@@ -23,10 +23,10 @@ export const WebRtcView: React.FunctionComponent<IWebRtcViewProps> = ({ jsep, mu
         jsep.startStream(onTrack).catch((error) => console.error(error));
     }, [jsep]);
 
-    // useEffect(() => {
-    //     if (!video.current) return;
-    //     video.current.volume = volume;
-    // }, [volume]);
+    useEffect(() => {
+        if (!video.current) return;
+        video.current.volume = volume;
+    }, [volume]);
 
     return (
         <video

diff --git a/packages/spectator/src/services/Jsep.ts b/packages/spectator/src/services/Jsep.ts
@@ -5,6 +5,7 @@ import type { ServerStreamingCall } from "@protobuf-ts/runtime-rpc";
 import { JsepMsg } from "@tinyburg/architect/protobuf/rtc_service.js";
 import { KeyboardEvent, MouseEvent, TouchEvent } from "@tinyburg/architect/protobuf/emulator_controller.js";
 
+// JavaScript Session Establishment Protocol
 // https://rtcweb-wg.github.io/jsep
 export class JsepProtocol {
     private readonly _rtcClient: IRtcClient;