Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS "Important" Review #21

Open
leriomaggio opened this issue Nov 30, 2020 · 0 comments
Open

CSS "Important" Review #21

leriomaggio opened this issue Nov 30, 2020 · 0 comments
Labels
enhancement New feature or request FIX Something isn't working

Comments

@leriomaggio
Copy link
Owner

The main CSS style contains by far too many !important restrictions!

Some of them are justified to override main jupyter and jupyter-light directives.
However my impression is that some (most?) of them could be simply avoided or removed as not needed.

Already started removing some of those for code link colour in ul/ol > li items.
Therefore, a thorough review is needed in order to clarify what is really !important and what is, instead, leftover from workarounds and development work.
@leriomaggio leriomaggio added enhancement New feature or request FIX Something isn't working labels Nov 30, 2020
leriomaggio added a commit that referenced this issue Dec 1, 2020
@leriomaggio
Colours link colors for mono in lists
3725079 
This is the first step towards removing not-really-necessary `!important` CSS clauses.
(See #21)
leriomaggio added a commit that referenced this issue Dec 1, 2020
@leriomaggio
Colours link colors for mono in lists
7d125ca 
This is the first step towards removing not-really-necessary `!important` CSS clauses.
(See #21)
leriomaggio added a commit that referenced this issue Dec 1, 2020
@leriomaggio
Link colours for mono and items in lists
9b2bdbb 
Initial removal of useless important clauses (see #21)
leriomaggio added a commit that referenced this issue Mar 29, 2021
@leriomaggio
CSS improvements and HTML Export fix
dcfd3dc 
Editor CSS has been changed by:
- removing bold font for keywords (not supported by all mono fonts nor necessary)
- removed italic for comments as imposed by default Jupyter theme (see above)
- Removed some useless `!important` clauses (Continuation of #21)
- FIX `.highlight > pre` to correctly specify Code font size and line-height.
- FIX directive for `span.cm-string` that was using the wrong CSS var.
leriomaggio added a commit that referenced this issue Mar 29, 2021
@leriomaggio
Removed some others important not that important #21
1793b6c
leriomaggio added a commit that referenced this issue Mar 29, 2021
@leriomaggio
#21 More useless important removed
1046cec 
This commit removes useless important clauses for:

- code cells (edit and display)
- md cells (edit)
- md cells headers (edit)
- md cells (display)
- links in md display cells (text-colour)
leriomaggio added a commit that referenced this issue Apr 8, 2021
@leriomaggio
#21 More useless important removed
f324655 
This commit removes useless important clauses for:

- code cells (edit and display)
- md cells (edit)
- md cells headers (edit)
- md cells (display)
- links in md display cells (text-colour)
leriomaggio added a commit that referenced this issue Apr 8, 2021
@leriomaggio
#21 More useless important removed and ANSI-colours vars.
c74eec2 
This commit removes useless important clauses for:

- code cells (edit and display)
- md cells (edit)
- md cells headers (edit)
- md cells (display)
- links in md display cells (text-colour)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request FIX Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leriomaggio