Fix no-prototype-builtins issues in Ruleset and ToCSSVisitor

less · Jul 15, 2024 · 8e488b2 · 8e488b2
1 parent 53f84f0
commit 8e488b2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/packages/less/src/less/tree/ruleset.js b/packages/less/src/less/tree/ruleset.js
@@ -295,8 +295,7 @@ Ruleset.prototype = Object.assign(new Node(), {
                 if (r.type === 'Import' && r.root && r.root.variables) {
                     const vars = r.root.variables();
                     for (const name in vars) {
-                        // eslint-disable-next-line no-prototype-builtins
-                        if (vars.hasOwnProperty(name)) {
+                        if (Object.prototype.hasOwnProperty.call(vars, name)) {
                             hash[name] = r.root.variable(name);
                         }
                     }

diff --git a/packages/less/src/less/visitors/to-css-visitor.js b/packages/less/src/less/visitors/to-css-visitor.js
@@ -303,19 +303,16 @@ ToCSSVisitor.prototype = {
         // remove duplicates
         const ruleCache = {};
 
-        let ruleList;
-        let rule;
-        let i;
-
-        for (i = rules.length - 1; i >= 0 ; i--) {
-            rule = rules[i];
+        for (let i = rules.length - 1; i >= 0 ; i--) {
+            let rule = rules[i];
             if (rule instanceof tree.Declaration) {
-                if (!ruleCache[rule.name]) {
+                if (!Object.prototype.hasOwnProperty.call(ruleCache, rule.name)) {
                     ruleCache[rule.name] = rule;
                 } else {
-                    ruleList = ruleCache[rule.name];
-                    if (ruleList instanceof tree.Declaration) {
-                        ruleList = ruleCache[rule.name] = [ruleCache[rule.name].toCSS(this._context)];
+                    let ruleList = ruleCache[rule.name];
+                    if (!Array.isArray(ruleList)) {
+                        const prevRuleCSS = ruleList.toCSS(this._context);
+                        ruleList = ruleCache[rule.name] = [prevRuleCSS];
                     }
                     const ruleCSS = rule.toCSS(this._context);
                     if (ruleList.indexOf(ruleCSS) !== -1) {

diff --git a/packages/test-data/css/_main/rulesets.css b/packages/test-data/css/_main/rulesets.css
@@ -1,5 +1,6 @@
 #first > .one {
   font-size: 2em;
+  hasOwnProperty: blue;
 }
 #first > .one > #second .two > #deux {
   width: 50%;

diff --git a/packages/test-data/less/_main/rulesets.less b/packages/test-data/less/_main/rulesets.less
@@ -27,4 +27,5 @@
     }
   }
   font-size: 2em;
+  hasOwnProperty: blue;
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,4 +27,5 @@ @@
         }
       }
       font-size: 2em;
+      hasOwnProperty: blue;
     }