Fix #2991 (#3649)

* Tests for 2991 * Fix for 2991 * chore: add missing newline Co-authored-by: Olivier Nicodemi <[email protected]> Co-authored-by: Lei Chen <[email protected]>
less · Aug 20, 2022 · eefe33a · eefe33a
1 parent 721659e
commit eefe33a
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 4 deletions.
diff --git a/packages/less/src/less/visitors/to-css-visitor.js b/packages/less/src/less/visitors/to-css-visitor.js
@@ -39,9 +39,9 @@ class CSSVisitorUtils {
             ? (rulesetNode.paths.length > 0) : false;
     }
 
-    resolveVisibility(node, originalRules) {
+    resolveVisibility(node) {
         if (!node.blocksVisibility()) {
-            if (this.isEmpty(node) && !this.containsSilentNonBlockedChild(originalRules)) {
+            if (this.isEmpty(node)) {
                 return ;
             }
 

diff --git a/packages/test-data/css/_main/css-3.css b/packages/test-data/css/_main/css-3.css
@@ -136,8 +136,6 @@ body > .shadow {
   symbols: ‣;
   suffix: " ";
 }
-@-ms-viewport {
-}
 @unknown foo 42 (bar) {
   x {
     y: z;

diff --git a/packages/test-data/less/_main/import-reference-issues.less b/packages/test-data/less/_main/import-reference-issues.less
@@ -5,6 +5,7 @@
 // * #2716 - A file imported by reference and then normally - multiple imports should be independent
 // * #1968 - When using an @import (reference), mixins that contain an & selector get added to the compiled output improperly
 // * #2162 - Cannot put import by reference inside of a mixin (also doubles #1896)
+// * #2991 - Empty @media queries generated through line comments when compiling less file with (reference)
 
 // #1878: extend inside referenced file should not extend outside selectors
 @import (reference) "import-reference-issues/global-scope-import.less";
@@ -48,3 +49,5 @@ show-all-content {
 call-mixin-with-import-by-reference-inside {
   .mixin-with-import-by-reference-inside();
 }
+
+@import (reference) "import-reference-issues/comments-2991.less";
diff --git a/packages/test-data/less/_main/import-reference-issues/comments-2991.less b/packages/test-data/less/_main/import-reference-issues/comments-2991.less
@@ -0,0 +1,25 @@
+.referenced {
+	// This file should not output anything if referenced.
+    @media (hover) {
+        // This file should not output anything if referenced.
+    }
+	// This file should not output anything if referenced.
+    @media (hover) {
+		// This file should not output anything if referenced.
+    }
+	// This file should not output anything if referenced.
+    @media (hover) {
+        /* This file should not output anything if referenced. */
+    }
+	// This file should not output anything if referenced.
+    @media (hover) {
+        color: #000000;
+    }
+}
+// This file should not output anything if referenced.
+@media (hover) {
+	// This file should not output anything if referenced.
+}
+@media (hover) {
+	/* This file should not output anything if referenced. */
+}