Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual synchronization function #24

Open
qbx2 opened this issue Feb 4, 2020 · 2 comments
Open

Add manual synchronization function #24

qbx2 opened this issue Feb 4, 2020 · 2 comments

Comments

@qbx2
Copy link

qbx2 commented Feb 4, 2020

Hello. First of all, thank you for sharing code and experiment results.
Reading the code, I found that the model will use fast weights to infer. According to LookAhead, fast weights (before synchronization) may perform worse than slow weights. By chance of (1-1/k) probability (80% when k=5), we will use unsynchronized fast weights to validate/test. Therefore, it should be better if we manually synchronize before evaluation.

@lessw2020
Copy link
Owner

Hi @qbx2 ,
Thanks for the feedback!
I think adding a manual sync is a good idea, along with a manual clear weights (for restarting new training).
I will try and add that later this week!
Thanks
Less

@qbx2
Copy link
Author

qbx2 commented Feb 5, 2020

Another minor issue: There is a typo N_sma_threshhold in ranger.py. It should be N_sma_threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants