Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade curl to 8.5.0 #20

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Upgrade curl to 8.5.0 #20

merged 8 commits into from
Apr 16, 2024

Conversation

perkfly
Copy link
Collaborator

@perkfly perkfly commented Jan 5, 2024

No description provided.

@perkfly perkfly linked an issue Jan 5, 2024 that may be closed by this pull request
2 tasks
@bjia56
Copy link
Collaborator

bjia56 commented Jan 8, 2024

NSS was removed in curl/curl@7c8bae0

We can see if reverting that commit in the upstream curl would allow NSS to be linked in again for Firefox, but unfortunately this may not be a long-term sustainable approach.

@perkfly
Copy link
Collaborator Author

perkfly commented Jan 8, 2024

That's a pretty big commit, I wonder if we would be able to revert it.

@perkfly
Copy link
Collaborator Author

perkfly commented Jan 9, 2024

Firefox starts to support ECH in recent versions, enabling that with NSS make things even worse.

@perkfly perkfly marked this pull request as draft January 9, 2024 06:54
@bjia56
Copy link
Collaborator

bjia56 commented Jan 9, 2024

So it sounds like we're out of luck with the Firefox build and need to emulate using BoringSSL starting curl 8.5?

@perkfly
Copy link
Collaborator Author

perkfly commented Jan 9, 2024

I'm afraid so, I still need to update the extensions and it should be done. I will first implement firefox120, other older versions should be similar. But if there are some ciphers that are too old to be added back, it won't be supported then.

Copy link

@T-256 T-256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's huge! Thank you <3

@T-256
Copy link

T-256 commented Apr 2, 2024

fyi I manually put libcurl.dll built via this release into curl_cffi.
It crashed on import on Python3.11

@perkfly perkfly marked this pull request as ready for review April 16, 2024 09:32
@perkfly perkfly force-pushed the feature/curl-8.5.0 branch from b4dd92a to a7629ee Compare April 16, 2024 09:36
@perkfly perkfly merged commit a8c85e8 into main Apr 16, 2024
19 of 22 checks passed
@perkfly perkfly mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants