Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put libcurl.dll next to _wapperd.pyd #190

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Conversation

T-256
Copy link
Contributor

@T-256 T-256 commented Dec 26, 2023

POC of #173 (Windows-only)

Drops delvewheel build-time dependency

image

For frozen pythons (like zipapps, pyinstaller, nuitka), the value of __file__ not pointing to curl_cffi/__init__.py, and then this patch won't get working.

Because _wrapper has only one shared-library dependency, I put them in same path together.

@perkfly
Copy link
Collaborator

perkfly commented Dec 26, 2023

Before working on this, I would recommend merge Windows build support into curl-impersonate first.

@T-256
Copy link
Contributor Author

T-256 commented Dec 26, 2023

I would recommend merge Windows build support into curl-impersonate first.

Should send PR to your fork of curl-impersonate? (as upstream is unmaintained for a while)
BTW, I don't think this PR is related to this. I can verify both 32 and 64 bit windows wheels of this working without problem.
You can get those wheels in my fork. I'm not sending main branch as PR, just for personal need, I created it to get 32bit windows build output.

@T-256 T-256 marked this pull request as ready for review December 26, 2023 15:21
@perkfly
Copy link
Collaborator

perkfly commented Dec 27, 2023

Currently, the Windows build uses mingw, I am not sure if it’s the best way or only way to build curl on Windows and it’s not working for 8.1.1 anyway.

I plan to build and release windows dlls directly from my fork of curl—impersonate, which may affect the dlls you are trying to fix here.

@perkfly
Copy link
Collaborator

perkfly commented Dec 27, 2023

Should send PR to your fork of curl-impersonate? (as upstream is unmaintained for a while)

The is tracked in lexiforest/curl-impersonate#4, if you are interested.

@T-256
Copy link
Contributor Author

T-256 commented Jan 19, 2024

@yifeikong Do you want consider review this as upstream issue has been closed?

@perkfly perkfly merged commit 8227621 into lexiforest:main Jan 19, 2024
3 checks passed
@T-256 T-256 deleted the libcurl branch January 19, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants