-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put libcurl.dll
next to _wapperd.pyd
#190
Conversation
Before working on this, I would recommend merge Windows build support into curl-impersonate first. |
Should send PR to your fork of |
Currently, the Windows build uses mingw, I am not sure if it’s the best way or only way to build curl on Windows and it’s not working for 8.1.1 anyway. I plan to build and release windows dlls directly from my fork of curl—impersonate, which may affect the dlls you are trying to fix here. |
The is tracked in lexiforest/curl-impersonate#4, if you are interested. |
@yifeikong Do you want consider review this as upstream issue has been closed? |
POC of #173 (Windows-only)
Drops
delvewheel
build-time dependencyFor frozen pythons (like zipapps, pyinstaller, nuitka), the value of
__file__
not pointing tocurl_cffi/__init__.py
, and then this patch won't get working.Because
_wrapper
has only one shared-library dependency, I put them in same path together.