Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type for session close #305

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add return type for session close #305

merged 1 commit into from
Apr 23, 2024

Conversation

tadasgedgaudas
Copy link
Contributor

Strict mypy is causing an issue:

error: Call to untyped function "close" in typed context  [no-untyped-call]

Which requires everyone with strict mypy to do:

await self.session.close()  # type: ignore

😿

@tadasgedgaudas tadasgedgaudas force-pushed the fix/session_close_return_type branch from 1d31858 to 7ff3b78 Compare April 23, 2024 14:06
@perklet perklet merged commit 9e68666 into lexiforest:main Apr 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tadasgedgaudas @perklet @tadasg6