Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability issues with VS Code extension #39

Open
edwardalee opened this issue Apr 11, 2022 · 4 comments
Open

Usability issues with VS Code extension #39

edwardalee opened this issue Apr 11, 2022 · 4 comments

Comments

@edwardalee
Copy link
Contributor

There are still some problems with usability here.

  1. When I build a .lf file, the stdout from the build process is nowhere to be seen. It is not obvious that anything has happened, nor do I know how to run the compiled code.
  2. The diagram view should default to below the code rather than to the right. Most diagrams are much wider than they are tall.
  3. I think the diagram view should open by default. It's pretty obscure, and hence will likely not help new users.
  4. Maybe the quick start instructions should point to some example LF projects/programs.
@lhstrh
Copy link
Member

lhstrh commented Apr 13, 2022

When building, a progress window like this should appear:
image

I agree that stdout and stderr need to be directed somewhere (it is currently hidden).

@soerendomroes
Copy link
Collaborator

The diagram view should default to below the code rather than to the right. Most diagrams are much wider than they are tall.

I currently did not find a quick solution for this. I will create a ticket in klighd-vscode for this feature since I think it is generally possible.

I think the diagram view should open by default. It's pretty obscure, and hence will likely not help new users.

We also like to have this feature in our kieler vscode extension. The corresponding ticket is tracked in kieler/klighd-vscode#39. I do, however, not remember the exact reason for this is also failed to document it properly.

@soerendomroes
Copy link
Collaborator

The diagram view should default to below the code rather than to the right. Most diagrams are much wider than they are tall.

VS Code only supports ViewColumns and not ViewRows, therefore, this is impossible. However, if the diagram widget is preserved it remains below if it was once moved there.

@soerendomroes
Copy link
Collaborator

The diagram view should default to below the code rather than to the right. Most diagrams are much wider than they are tall.

I currently did not find a quick solution for this. I will create a ticket in klighd-vscode for this feature since I think it is generally possible.

I think the diagram view should open by default. It's pretty obscure, and hence will likely not help new users.

We also like to have this feature in our kieler vscode extension. The corresponding ticket is tracked in kieler/klighd-vscode#39. I do, however, not remember the exact reason for this is also failed to document it properly.

These issues will be fixed via kieler/klighd-vscode#100 and the behavior is the following:
If the klighd-vscode extension is first used in a vscode it will try to open the diagram to the right. As mentioned before VS Code does not support opening something below.
If one moves the diagram below it will be reopened below if the vscode is restarted/reloaded again.
If the diagram was explicitly closed it will not open again after a restart/reload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants