fix new DB path #49
Merged
fix new DB path #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome .... this is exactly the "real" solution to this issue. Thanks a lot ...... @liamcain please merge this. |
|
Thanks for the fix yarnaid! I'm looking forward to seeing this working again once it's been merged by @liamcain |
piazzatron
reviewed
Sep 8, 2023
There was a problem hiding this comment.
May as well bikeshed while waiting for approval :) great work @yarnaid
Co-authored-by: Michael Piazza <[email protected]>
Co-authored-by: Michael Piazza <[email protected]>
|
It would be awesome to see this merged 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Things documentation they now use a dynamic path to DB, and the old one doesn't work. Here is the fix
resolve issue #44