Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LOOPSTART/LOOPLENGTH and LOOPEND tags on more than 2 channels #92

Open
SolaceEllery opened this issue Oct 1, 2023 · 2 comments

Comments

@SolaceEllery
Copy link

When I exported an OGG (With LOOPSTART and LOOPEND tags, without an LOOPLENGTH tag) to BRSTM, it didn't loop properly at all. So for the next version, I was thinking maybe will there be support for the LOOPSTART/LOOPLENGTH tags when converting ordinary WAV/OGGs to BRSTM-like formats so things can loop properly?

(I also tested LOOPLENGTH and it's also not looping properly, so you'll might wanna check up on that as well)

Expected WAV file: https://github.com/SpencerEverly/smasplusplus-flps/blob/main/Super%20Mario%20Bros%20Spencer/FLPs/Final%20WAVs/Another%20World.wav
What LoopingAudioConverter spits out: https://drive.google.com/file/d/1or25sSgToXrrl302Qvi1tDqWI5i9MjE5/view?usp=drive_link

@SolaceEllery SolaceEllery changed the title Add support for LOOPSTART and LOOPEND tags Add support for LOOPSTART/LOOPLENGTH and LOOPEND tags Oct 1, 2023
@SolaceEllery
Copy link
Author

SolaceEllery commented Oct 1, 2023

I tested this with the original stereo version without Yoshi beats and it worked. So it must be an issue with it being more than 2 channels

@SolaceEllery SolaceEllery changed the title Add support for LOOPSTART/LOOPLENGTH and LOOPEND tags Add support for LOOPSTART/LOOPLENGTH and LOOPEND tags on more than 2 channels Oct 1, 2023
@libertyernie
Copy link
Owner

Do you have the original ogg file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants