Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image downloads #7

Open
ruanchaves opened this issue Jun 26, 2019 · 13 comments
Open

Image downloads #7

ruanchaves opened this issue Jun 26, 2019 · 13 comments
Labels
enhancement New feature or request

Comments

@ruanchaves
Copy link

Please consider integrating the features of my image plugin to this repository.

@github-userx
Copy link

github-userx commented Jun 26, 2019 via email

@libertysoft3
Copy link
Owner

Awesome man, I love it. So this grabs all images that are linked to anywhere, as in link posts, text posts, and comments? Should we also try to get post thumbnails?

If you want to keep pushing on this OP, we can come up with some command line flags that should be supported, and we can work towards a pull request.

I can see people wanting to limit how many images per post are downloaded, maybe a max file size parameter, etc. Good stuff.

@ruanchaves
Copy link
Author

ruanchaves commented Jun 26, 2019

Nice. I still have to read your code, I wrote this in a hurry.

I'll read your code and try to submit a pull request that fits in nicely.

This grabs all images ever everywhere, including thumbnails.

@ghost
Copy link

ghost commented Jun 26, 2019

This is great! Looking forward to it.

@ruanchaves
Copy link
Author

I'll be overbooked for the next few weeks so I plan to work on this during late July.
In the meanwhile whoever needs this can use the plugin as it just works anyway.

@libertysoft3
Copy link
Owner

Re-opening because people are interested in this. An open issue can collect votes.

@pullup
Copy link

pullup commented Jul 7, 2019

Awesome man, I love it. So this grabs all images that are linked to anywhere, as in link posts, text posts, and comments? Should we also try to get post thumbnails?

If you want to keep pushing on this OP, we can come up with some command line flags that should be supported, and we can work towards a pull request.

I can see people wanting to limit how many images per post are downloaded, maybe a max file size parameter, etc. Good stuff.

Thumbnails would make this a god tier program I'd use daily

@Code-Slave
Copy link

could this be expanded for yt vids? use youtub-dl or similiar?

@github-userx
Copy link

github-userx commented Jul 18, 2019 via email

@libertysoft3
Copy link
Owner

I think offline videos are possible.. can someone do an offline test of a webpage with an html5 video tag with a local and relative file path as the source?

@bavarianblacksmith
Copy link

Great work. Just wanted to add that having the images correspond to the folder thread would be great. Would also be a nice feature if the plugin was able to save html web pages that are linked from the subreddit archive.

@CrimsonVex
Copy link

Status on this?

@ruanchaves
Copy link
Author

My plans to work on this plugin have miserably failed.

But as of today, there's already the RedditDownloader repository where people have already done most of the hard work.

I'm not sure if this repository is still being actively developed ( or even if it still works ), but integrating both repositories seems to be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants