Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D case for winding number / sdf computation #122

Open
ottogin opened this issue Feb 7, 2022 · 1 comment · May be fixed by #243
Open

2D case for winding number / sdf computation #122

ottogin opened this issue Feb 7, 2022 · 1 comment · May be fixed by #243

Comments

@ottogin
Copy link

ottogin commented Feb 7, 2022

The C++ backend of IGL supports 2D cases in SDF and winding number (except for fast-winding number). However, the bindings have the assert that raises the following error on the 2D data:

ValueError: Invalid mesh vertices, v must have shape [#vertices, 3] but got v.shape = [25, 2]
@arvigj
Copy link

arvigj commented Aug 19, 2024

This case fails only on the assert, can we make the assert only if V.shape[1] == 3 and check if V.shape[1] == 2? Otherwise, if this is not safe enough, can we get a triangle mesh and take the boundary loop inside the binding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants