Update sdk test certs #2449
Closed
Update sdk test certs #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran ./api/server/sdk/test_certs/refresh.sh Signed-off-by: Neelesh Thakur <[email protected]>
pp511
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Your tests passed howeve based on the instructions here https://github.com/libopenstorage/openstorage/blob/master/api/server/sdk/test_certs/refresh.sh I think insecure* files also needed to be updated?
I had also created a PR #2450 as I wasn't sure you were going to update them right away and all files got updated when running refresh.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Explain the PR and why it is needed.
Which issue(s) this PR fixes (optional)
Closes #
or
PWX-
Testing Notes
Add testing output or passing unit test output here.
Special notes for your reviewer:
Add any notes for the reviewer here.