From 7fa2d5c15573e7d9caf4b4badd7f294bfdf20526 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Magiera?= Date: Thu, 30 Aug 2018 15:53:42 +0200 Subject: [PATCH 1/3] ValueStore.SearchValue --- routing.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/routing.go b/routing.go index 2ddfc4c..4b51cd7 100644 --- a/routing.go +++ b/routing.go @@ -51,14 +51,13 @@ type ValueStore interface { // GetValue searches for the value corresponding to given Key. GetValue(context.Context, string, ...ropts.Option) ([]byte, error) - // TODO // SearchValue searches for better and better values from this value // store corresponding to the given Key. Implementations may halt the // search after a period of time or may continue searching indefinitely. // // Useful when you want a result *now* but still want to hear about // better/newer results. - //SearchValue(context.Context, string, ...ropts.Option) (<-chan []byte, error) + SearchValue(context.Context, string, ...ropts.Option) (<-chan []byte, error) } // IpfsRouting is the combination of different routing types that ipfs From f5c8e7e87fa0a7ac9b56d6adebb2db3a5df07a5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Magiera?= Date: Mon, 24 Sep 2018 13:13:37 +0200 Subject: [PATCH 2/3] gx publish 2.6.0 --- .gx/lastpubver | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gx/lastpubver b/.gx/lastpubver index 6b8851a..7b56355 100644 --- a/.gx/lastpubver +++ b/.gx/lastpubver @@ -1 +1 @@ -2.5.0: QmdKS5YtmuSWKuLLgbHG176mS3VX3AKiyVmaaiAfvgcuch +2.6.0: QmaJ6QDUh7JKPPToaUZ4EtUsPBdrbSAG6zMTkzfEvZgz2j diff --git a/package.json b/package.json index 6963361..65a8ccf 100644 --- a/package.json +++ b/package.json @@ -37,6 +37,6 @@ "license": "MIT", "name": "go-libp2p-routing", "releaseCmd": "git commit -a -m \"gx publish $VERSION\"", - "version": "2.5.0" + "version": "2.6.0" } From 992c68dfbf22803b4bba814887ee456a23803320 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Magiera?= Date: Sat, 1 Sep 2018 14:04:18 +0200 Subject: [PATCH 3/3] SearchValue: note on not found behaviour --- routing.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/routing.go b/routing.go index 4b51cd7..d187287 100644 --- a/routing.go +++ b/routing.go @@ -57,6 +57,9 @@ type ValueStore interface { // // Useful when you want a result *now* but still want to hear about // better/newer results. + // + // Implementations of this methods won't return ErrNotFound. When a value + // couldn't be found, the channel will get closed without passing any results SearchValue(context.Context, string, ...ropts.Option) (<-chan []byte, error) }