-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for equal preference cipher groups #66
Comments
Unless you use SSL_OP_CIPHER_SERVER_PREFERENCE, the first matching cipher based on the client's preference should be used - are you suggesting this is not the case? That said, it is currently true that a LibreSSL client will prefer ChaCha20-Poly1305 to any other cipher suite. |
When not explicitly using I really like BoringSSL's approach to equally group ciphers. Are there plans to support group-like cipherlists in the near future? |
CloudFlares approach is a hack, I like the BoringSSL equal-preference groups approach. I'm crossing fingers that LibreSSL picks this up too, if so then I can stop using BoringSSL :) It's described in more detail here: include/openssl/ssl.h#638 Rationale and blog posts: |
Since r1.81 of ssl_ciph.c, AES has been preferred over Chacha20+Poly1305, if the host has hardware support for AES. That said, we're still looking at supporting equal preference groups. |
👍 Also see this commit: libressl/openbsd@1958d57 I've just recompiled nginx + libressl (r 1.83 of ssl_ciph.c), but my AES-NI capable server still uses CHACHA20_POLY1305.. What am I doing wrong? |
History disproves the hypothesis; See below.
Then many lazy server administrators left their servers RC4-preferred or even RC4-only even after 1/n-1 record splitting mitigated the BEAST and many attacks to RC4 are reported. |
Do we have any update or ETA on this feature ? |
I'd love to know the status of this as well. |
btw: nginx now supports setting arbitrary |
Great! Should be released on 27/10/2020 with nginx 1.19.4 release: https://trac.nginx.org/nginx/milestone/nginx-1.19.4. |
ChaCha20+Poly1305 should only be used if it is the top client's cipher.
AES with AES-NI outperforms ChaCha20 (1350 bytes benchmark):
=> AES with AES-NI is ~twice as fast, thus should be the preferred cipher suite.
Maybe it is a good idea to introduce equal preference groups, like BoringSSL recently added.
[ECDHE-RSA-AES128-GCM-SHA256|ECDHE-RSA-CHACHA20-POLY1305]:ECDHE-ECDSA-AES256-GCM-SHA384:…
Also see cloudflare's openssl patch: https://github.com/cloudflare/sslconfig/blob/master/patches/openssl__chacha20_poly1305_cf.patch#L4191
The text was updated successfully, but these errors were encountered: