Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wavpack misses ftruncate #585

Closed
madebr opened this issue Jan 15, 2024 · 3 comments · Fixed by #586
Closed

wavpack misses ftruncate #585

madebr opened this issue Jan 15, 2024 · 3 comments · Fixed by #586
Milestone

Comments

@madebr
Copy link
Contributor

madebr commented Jan 15, 2024

Building SDL_mixer's playmus for ps2 and psp (on ci), linking fails with:

  /tmp/setupsdl/da8de0a910961c86f12e0e6d22427875f5c38084675d3be163533c2ff1367bcc/source/external/wavpack/src/open_filename.c:208:(.text+0x40): undefined reference to `ftruncate'
  collect2: error: ld returned 1 exit status

This probably means wavpack is missing a link to the math library.
Or the toolchain does not provide this symbol.

@slouken
Copy link
Collaborator

slouken commented Jan 15, 2024

ftruncate is a file truncation call. If there isn't an upstream workaround, let's go ahead and disable wavpack on PS2 by default.

@slouken slouken added this to the 2.8.0 milestone Jan 15, 2024
@sezero
Copy link
Contributor

sezero commented Jan 15, 2024

We don't use that part of the library: Can we conditionally add something, even some stub, to the library for PS? builds?

@madebr
Copy link
Contributor Author

madebr commented Jan 15, 2024

See libsdl-org/WavPack#2 and #586

The wavpack patch should be applied first, so ci can run on the SDL_mixer patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants