Skip to content

Commit

Permalink
Add IMPORTED_IMPLIB property to each CMake Module (AOMediaCodec#2425)
Browse files Browse the repository at this point in the history
  • Loading branch information
y-guyon authored Sep 2, 2024
1 parent c799319 commit 85979a7
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cmake/Modules/Findaom.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@ if(AOM_LIBRARY)
else()
add_library(aom SHARED IMPORTED GLOBAL)
endif()
set_target_properties(aom PROPERTIES IMPORTED_LOCATION "${AOM_LIBRARY}")
set_target_properties(aom PROPERTIES IMPORTED_LOCATION "${AOM_LIBRARY}" IMPORTED_IMPLIB "${AOM_LIBRARY}")
target_include_directories(aom INTERFACE ${AOM_INCLUDE_DIR})
endif()
2 changes: 1 addition & 1 deletion cmake/Modules/Finddav1d.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ if(DAV1D_LIBRARY)
add_library(dav1d::dav1d SHARED IMPORTED GLOBAL)
endif()
set_target_properties(
dav1d::dav1d PROPERTIES IMPORTED_LOCATION "${DAV1D_LIBRARY}" IMPORTED_SONAME dav1d IMPORTED_IMPLIB "${DAV1D_LIBRARY}"
dav1d::dav1d PROPERTIES IMPORTED_LOCATION "${DAV1D_LIBRARY}" IMPORTED_IMPLIB "${DAV1D_LIBRARY}" IMPORTED_SONAME dav1d
)
target_include_directories(dav1d::dav1d INTERFACE ${DAV1D_INCLUDE_DIR})
endif()
5 changes: 4 additions & 1 deletion cmake/Modules/Findlibgav1.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ mark_as_advanced(LIBGAV1_INCLUDE_DIR LIBGAV1_LIBRARY LIBGAV1_LIBRARIES)

if(LIBGAV1_LIBRARY)
add_library(libgav1::libgav1 STATIC IMPORTED GLOBAL)
set_target_properties(libgav1::libgav1 PROPERTIES IMPORTED_LOCATION "${LIBGAV1_LIBRARY}" IMPORTED_SONAME gav1)
set_target_properties(
libgav1::libgav1 PROPERTIES IMPORTED_LOCATION "${LIBGAV1_LIBRARY}" IMPORTED_IMPLIB "${LIBGAV1_LIBRARY}" IMPORTED_SONAME
gav1
)
target_include_directories(libgav1::libgav1 INTERFACE ${LIBGAV1_INCLUDE_DIR})
endif()
5 changes: 4 additions & 1 deletion cmake/Modules/Findlibsharpyuv.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ if(LIBSHARPYUV_LIBRARY)
else()
add_library(sharpyuv::sharpyuv SHARED IMPORTED GLOBAL)
endif()
set_target_properties(sharpyuv::sharpyuv PROPERTIES IMPORTED_LOCATION "${LIBSHARPYUV_LIBRARY}" IMPORTED_SONAME sharpyuv)
set_target_properties(
sharpyuv::sharpyuv PROPERTIES IMPORTED_LOCATION "${LIBSHARPYUV_LIBRARY}" IMPORTED_IMPLIB "${LIBSHARPYUV_LIBRARY}"
IMPORTED_SONAME sharpyuv
)
target_include_directories(sharpyuv::sharpyuv INTERFACE "${LIBSHARPYUV_INCLUDE_DIR}")
endif()
4 changes: 3 additions & 1 deletion cmake/Modules/Findlibyuv.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ if(LIBYUV_LIBRARY)
else()
add_library(yuv::yuv SHARED IMPORTED GLOBAL)
endif()
set_target_properties(yuv::yuv PROPERTIES IMPORTED_LOCATION "${LIBYUV_LIBRARY}" IMPORTED_SONAME yuv)
set_target_properties(
yuv::yuv PROPERTIES IMPORTED_LOCATION "${LIBYUV_LIBRARY}" IMPORTED_IMPLIB "${LIBYUV_LIBRARY}" IMPORTED_SONAME yuv
)
target_include_directories(yuv::yuv INTERFACE "${LIBYUV_INCLUDE_DIR}")
set(libyuv_FOUND ON)
endif()
4 changes: 3 additions & 1 deletion cmake/Modules/Findrav1e.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ if(RAV1E_LIBRARY)
else()
add_library(rav1e::rav1e SHARED IMPORTED GLOBAL)
endif()
set_target_properties(rav1e::rav1e PROPERTIES IMPORTED_LOCATION "${RAV1E_LIBRARY}" IMPORTED_SONAME rav1e)
set_target_properties(
rav1e::rav1e PROPERTIES IMPORTED_LOCATION "${RAV1E_LIBRARY}" IMPORTED_IMPLIB "${RAV1E_LIBRARY}" IMPORTED_SONAME rav1e
)
target_include_directories(rav1e::rav1e INTERFACE ${RAV1E_INCLUDE_DIR})
# The following is copied from the main CMakeLists.txt.
if(WIN32)
Expand Down
2 changes: 1 addition & 1 deletion cmake/Modules/Findsvt.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ if(SVT_LIBRARY)
else()
add_library(SvtAv1Enc SHARED IMPORTED GLOBAL)
endif()
set_target_properties(SvtAv1Enc PROPERTIES IMPORTED_LOCATION "${SVT_LIBRARY}")
set_target_properties(SvtAv1Enc PROPERTIES IMPORTED_LOCATION "${SVT_LIBRARY}" IMPORTED_IMPLIB "${SVT_LIBRARY}")
target_include_directories(SvtAv1Enc INTERFACE ${SVT_INCLUDE_DIR})
endif()

0 comments on commit 85979a7

Please sign in to comment.