Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More color correction options #1

Open
outerwinnie opened this issue Aug 3, 2022 · 16 comments
Open

More color correction options #1

outerwinnie opened this issue Aug 3, 2022 · 16 comments
Labels
enhancement New feature or request

Comments

@outerwinnie
Copy link

Hi! I was wondering is it would be possible to add color correction settings to the plugin, with the objetive of manage something like this but system wide:

https://www.reddit.com/r/SteamDeck/comments/wd2fa7/get_a_more_color_accurate_steam_deck_files/
https://www.reddit.com/r/SteamDeck/comments/v80w7u/steam_deck_display_calibration_v2/

Thanks for your work! Amazing plugin!

@Scrumplex
Copy link
Member

I don't think you can set LUTs directly, as they are used in those posts. But color correction is definitely possible.

For future reference, these are all color values, that can be altered in Gamescope: https://github.com/Plagman/gamescope/blob/3122d1aabec4d8f7df79edb1b76e136c0dd5ffbf/src/steamcompmgr.cpp#L4937-L4942

@outerwinnie
Copy link
Author

Well, it would be amazing if you add those options at some point! Thanks again!

@aizakow
Copy link

aizakow commented Aug 4, 2022

I second this! Some way to match the calibration of those reshade configs would be amazing

@Scrumplex Scrumplex added the enhancement New feature or request label Aug 4, 2022
@Scrumplex Scrumplex changed the title Would it be possible to add color correction options to the plugin? (Request) More color correction options Aug 4, 2022
@crystalclear23
Copy link

I third this.

@rc2189
Copy link

rc2189 commented Aug 14, 2022

It seems like changing the gamma would be the next best addition:

GAMESCOPE_COLOR_GAMMA_EXPONENT

I tinkered around with it for a little while but never got it fully working

@rc2189
Copy link

rc2189 commented Aug 17, 2022

@Scrumplex any chance you can add settings to change the gamma? In my opinion the deck could really benefit from those changes! I can collaborate if needed

@Scrumplex
Copy link
Member

I have looked at the relevant code inside gamescope. That variables takes six float values. The first three are the exponents for degamma (I assume R, G and B) and the latter three are for gamma (also R, G and B).
Does anyone know what degamma is? :D

@rc2189
Copy link

rc2189 commented Aug 17, 2022

I have looked at the relevant code inside gamescope. That variables takes six float values. The first three are the exponents for degamma (I assume R, G and B) and the latter three are for gamma (also R, G and B). Does anyone know what degamma is? :D

I only dug through a bit, but that would make sense RGB then Gamma. Hopefully this is something that can be accomplished!

Scrumplex added a commit that referenced this issue Aug 18, 2022
In an effort to support more color correction options, add gamma color
exponent settings. See #1

This lacks degamma values. Not sure if anyone wants them though.
@rc2189
Copy link

rc2189 commented Aug 19, 2022

I see a commit for this, huge thank you for considering adding the gamma! Hugely appreciated!

@crystalclear23
Copy link

How do you install the new version or do I just wait for it on decky?

Scrumplex added a commit that referenced this issue Aug 19, 2022
In an effort to support more color correction options, add gamma color
exponent settings. See #1

This lacks degamma values. Not sure if anyone wants them though.
Scrumplex added a commit that referenced this issue Aug 27, 2022
In an effort to support more color correction options, add gamma color
exponent settings. See #1

This lacks degamma values. Not sure if anyone wants them though.
Scrumplex added a commit that referenced this issue Aug 27, 2022
In an effort to support more color correction options, add gamma color
gain settings. See #1

This does not include support for setting degamma/gamma exponents, as
there needs to be a user-friendly way of setting them.
Scrumplex added a commit that referenced this issue Aug 27, 2022
In an effort to support more color correction options, add gamma color
gain settings. See #1

This does not include support for setting degamma/gamma exponents, as
there needs to be a user-friendly way of setting them.
@Scrumplex
Copy link
Member

Gamma support is basically ready with PR #8.

I asked in Decky Discord for people to test it. If no issues surface, I will release a new version with gamma setting soon

@rc2189
Copy link

rc2189 commented Aug 27, 2022

Fantastic, thank you!

@crystalclear23
Copy link

Is there a way to edit the index.js so that the increments are like 5 instead of 50

@aizakow
Copy link

aizakow commented Sep 1, 2022

The latest version appears to disable night mode whenever I launch a game, permanently until I go into system settings and turn it back on. Is this intended behavior? I sort of see the reasoning, but a toggle might be nice

@Scrumplex
Copy link
Member

Is there a way to edit the index.js so that the increments are like 5 instead of 50

I can't influence that sadly. If you use the touchscreen, you can set finer values

@Scrumplex
Copy link
Member

The latest version appears to disable night mode whenever I launch a game, permanently until I go into system settings and turn it back on. Is this intended behavior? I sort of see the reasoning, but a toggle might be nice

Steam also uses some way of editing gamma values. I am still not sure how they do it, but you (currently) can't have both

@Scrumplex Scrumplex mentioned this issue Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants