Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final value on slide stop doesn't get sent to action handlers #27

Open
steveklewis opened this issue Nov 28, 2016 · 2 comments
Open

Final value on slide stop doesn't get sent to action handlers #27

steveklewis opened this issue Nov 28, 2016 · 2 comments

Comments

@steveklewis
Copy link

steveklewis commented Nov 28, 2016

I'm using Ember 2.9 and ui-slider 0.4.1. I've upgraded from ui-slider 0.3.5. seiyria-bootstrap-slider is at 7.1.1.

The behavior I'm seeing is that I can drag the slider but only the first value that was changed gets fired. If I have 1,2,3 and I start at 1, and drag to 3, the value in the handler is 2, and never 3.

I've looked at the examples and feel like I'm doing something very similar (the main change was sending sizeFilterTicks and sizeFilterTickLabels a string, instead of an array).

The major difference is that I'm setting my min & max & ticks, etc. from within my component that's using ui-slider, rather than passing in the scalar values in the template. Is there a specific lifecycle hook that I should be using? didReceiveAttrs doesn't seem to be adequate.

@steveklewis
Copy link
Author

I've recreated a very basic component with a slider, and in my barebones app I get the opposite behavior: the change event only seems to get called on mouseup, so the final value is included in the event.

My guess is that I will have to Ember.observe the value to get this to work similarly to what I had before.

@yankeeinlondon
Copy link
Member

Hmmm. I have not seen this behaviour. Can you reproduce in a twiddle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants