Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acrossv3 hotfix [AcrossFacetPackedV3 v1.2.0,ReceiverAcrossV3 v1.0.1] #897

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Acrossv3 hotfix [AcrossFacetPackedV3 v1.2.0,ReceiverAcrossV3 v1.0.1] #897

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4b24a76
Add depositor to packed params
ezynda3 Dec 6, 2024
56aebd5
Drop gas introspection in receiver contract
ezynda3 Dec 6, 2024
d2415f5
Merge branch 'main' of github.com:lifinance/contracts into acrossv3-h…
ezynda3 Dec 6, 2024
efeab77
Deploy to staging
ezynda3 Dec 6, 2024
cf35ee4
Fix types CI job
ezynda3 Dec 6, 2024
d1f9dd9
Bump versions
ezynda3 Dec 6, 2024
5f59b49
Add comments removed by mistake
ezynda3 Dec 6, 2024
9a8ff40
Update min methods to use depositor as well
ezynda3 Dec 6, 2024
3d7eb03
Attach audit report
ezynda3 Dec 6, 2024
cd471a9
Fix log
ezynda3 Dec 6, 2024
ac60f3f
Update logs
ezynda3 Dec 9, 2024
48d3139
Deploy to zksync
ezynda3 Dec 10, 2024
d75d0a0
Update logs
ezynda3 Dec 12, 2024
20affd6
Update logs for blast and mode
ezynda3 Dec 12, 2024
34dcdc1
Update logs for linea
ezynda3 Dec 12, 2024
3bdbf13
Merge branch 'main' into acrossv3-hotfix
ezynda3 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ jobs:
run: |
cd lifi-contract-types
TMP=$(mktemp)
jq '.version="${NEW_VERSION}"' package.json > "$TMP" && mv "$TMP" package.json
jq --arg new_ver "$NEW_VERSION" '.version=$new_ver' package.json > "$TMP" && mv "$TMP" package.json
git config user.name github-actions
git config user.email [email protected]
echo "Updating version from $LATEST_TAG to $NEW_VERSION"
Expand Down
63 changes: 50 additions & 13 deletions audit/auditLog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,42 +55,79 @@
"auditorGitHandle": "sujithsomraaj",
"auditReportPath": "./audit/reports/2024.12.03_LiFiDexAggregator.pdf",
"auditCommitHash": "8a34562c912b5b19c919bb95338655c944428af5"
},
"audit20241206": {
"auditCompletedOn": "06.12.2024",
"auditedBy": "Sujith Somraaj (individual security researcher)",
"auditorGitHandle": "sujithsomraaj",
"auditReportPath": "./audit/reports/2024.12.06_AcrossFacetPackedV3(v1.2.0).pdf",
"auditCommitHash": "5f59b4957fe315ea2d7b5e9daa931785ccff488c"
}
},
"auditedContracts": {
"AcrossFacetV3": {
"1.0.0": ["audit20241007"]
"1.0.0": [
"audit20241007"
]
},
"AcrossFacetPackedV3": {
"1.0.0": ["audit20241007"]
"1.0.0": [
"audit20241007"
],
"1.2.0": [
"audit20241206"
]
},
"GasZipFacet": {
"2.0.0": ["audit20241107"]
"2.0.0": [
"audit20241107"
]
},
"GasZipPeriphery": {
"1.0.0": ["audit20241107"]
"1.0.0": [
"audit20241107"
]
},
"IGasZip": {
"1.0.0": ["audit20241107"]
"1.0.0": [
"audit20241107"
]
},
"EmergencyPauseFacet": {
"1.0.0": ["audit20240913"],
"1.0.1": ["audit20241105"]
"1.0.0": [
"audit20240913"
],
"1.0.1": [
"audit20241105"
]
},
"LiFiDEXAggregator": {
"1.5.0": ["audit20241203"]
"1.5.0": [
"audit20241203"
]
},
"Permit2Proxy": {
"1.0.0": ["audit20241122"]
"1.0.0": [
"audit20241122"
]
},
"ReceiverAcrossV3": {
"1.0.0": ["audit20241007"]
"1.0.0": [
"audit20241007"
],
"1.0.1": [
"audit20241206"
]
},
"StargateFacetV2": {
"1.0.1": ["audit20240814"]
"1.0.1": [
"audit20240814"
]
},
"WithdrawablePeriphery": {
"1.0.0": ["audit20241014"]
"1.0.0": [
"audit20241014"
]
}
}
}
}
Binary file added audit/reports/2024.12.06_AcrossFacetPackedV3(v1.2.0).pdf
View file
Open in desktop
Binary file not shown.
44 changes: 34 additions & 10 deletions deployments/_deployments_log_file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24427,12 +24427,12 @@
"staging": {
"1.0.0": [
{
"ADDRESS": "0xe2e5428F972d9C0a5Ba433e0c402752b472dB248",
"ADDRESS": "0xAd99305a4277B417d1711CB358Dcf124181Ec3C3",
"OPTIMIZER_RUNS": "1000000",
"TIMESTAMP": "2024-06-14 09:37:49",
"TIMESTAMP": "2024-12-06 20:05:58",
"CONSTRUCTOR_ARGS": "0x0000000000000000000000009295ee1d8c5b022be115a2ad3c30c72e34e7f0960000000000000000000000007ceb23fd6bc0add59e62ac25578270cff1b9f619",
"SALT": "",
"VERIFIED": "false"
"VERIFIED": "true"
ezynda3 marked this conversation as resolved.
Show resolved Hide resolved
}
]
},
Expand Down Expand Up @@ -24645,12 +24645,12 @@
"staging": {
"1.0.0": [
{
"ADDRESS": "0x3877f47B560819E96BBD7e7700a02dfACe36D696",
"ADDRESS": "0xe4F3DEF14D61e47c696374453CD64d438FD277F8",
"OPTIMIZER_RUNS": "1000000",
"TIMESTAMP": "2024-07-31 16:59:18",
"TIMESTAMP": "2024-12-06 12:41:24",
"CONSTRUCTOR_ARGS": "0x000000000000000000000000156cebba59deb2cb23742f70dcb0a11cc775591f00000000000000000000000023f882ba2fa54a358d8599465eb471f58cc26751000000000000000000000000e35e9842fceaca96570b734083f4a58e8f7c5f2a00000000000000000000000000000000000000000000000000000000000186a0",
"SALT": "31072024",
"VERIFIED": "false"
"SALT": "",
"VERIFIED": "true"
}
]
},
Expand Down Expand Up @@ -24707,6 +24707,18 @@
"VERIFIED": "true"
}
]
},
"staging": {
"1.0.0": [
{
"ADDRESS": "0xe4F3DEF14D61e47c696374453CD64d438FD277F8",
"OPTIMIZER_RUNS": "1000000",
"TIMESTAMP": "2024-12-06 12:40:08",
"CONSTRUCTOR_ARGS": "0x000000000000000000000000156cebba59deb2cb23742f70dcb0a11cc775591f00000000000000000000000023f882ba2fa54a358d8599465eb471f58cc267510000000000000000000000009295ee1d8c5b022be115a2ad3c30c72e34e7f09600000000000000000000000000000000000000000000000000000000000186a0",
"SALT": "",
"VERIFIED": "true"
}
]
}
},
"blast": {
Expand Down Expand Up @@ -24872,6 +24884,18 @@
"VERIFIED": "true"
}
]
},
"staging": {
"1.0.0": [
{
"ADDRESS": "0x21767081Ff52CE5563A29f27149D01C7127775A2",
"OPTIMIZER_RUNS": "1000000",
"TIMESTAMP": "2024-12-06 12:34:11",
"CONSTRUCTOR_ARGS": "0x0000000000000000000000009295ee1d8c5b022be115a2ad3c30c72e34e7f0960000000000000000000000007ceb23fd6bc0add59e62ac25578270cff1b9f619000000000000000000000000b9c0de368bece5e76b52545a8e377a4c118f597b",
"SALT": "",
"VERIFIED": "true"
}
]
}
},
"base": {
Expand Down Expand Up @@ -24904,9 +24928,9 @@
"staging": {
"1.0.0": [
{
"ADDRESS": "0x4352459F6BE1C7D1278F8c34Bb598b0feeB50f8b",
"ADDRESS": "0x21767081Ff52CE5563A29f27149D01C7127775A2",
"OPTIMIZER_RUNS": "1000000",
"TIMESTAMP": "2024-10-03 07:44:55",
"TIMESTAMP": "2024-12-06 12:24:22",
"CONSTRUCTOR_ARGS": "0x000000000000000000000000e35e9842fceaca96570b734083f4a58e8f7c5f2a00000000000000000000000082af49447d8a07e3bd95bd0d56f35241523fbab1000000000000000000000000b9c0de368bece5e76b52545a8e377a4c118f597b",
"SALT": "",
"VERIFIED": "true"
Expand Down Expand Up @@ -25749,4 +25773,4 @@
}
}
}
}
}
6 changes: 3 additions & 3 deletions deployments/arbitrum.staging.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@
"EmergencyPauseFacet": "0x17Bb203F42d8e404ac7E8dB6ff972B7E8473850b",
"Permit2Proxy": "0x6FC01BC9Ff6Cdab694Ec8Ca41B21a2F04C8c37E5",
"AcrossFacetV3": "0x6124C65B6264bE13f059b7C3A891a5b77DA8Bd95",
"ReceiverAcrossV3": "0x3877f47B560819E96BBD7e7700a02dfACe36D696",
"AcrossFacetPackedV3": "0x4352459F6BE1C7D1278F8c34Bb598b0feeB50f8b"
}
"ReceiverAcrossV3": "0xe4F3DEF14D61e47c696374453CD64d438FD277F8",
"AcrossFacetPackedV3": "0x21767081Ff52CE5563A29f27149D01C7127775A2"
}
8 changes: 5 additions & 3 deletions deployments/polygon.staging.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
"CelerCircleBridgeFacet": "0x371E073f6A09DCBEE1D2Ac56E940F878a0Ba9DAE",
"HopFacetOptimized": "0xf82135385765f1324257ffF74489F16382EBBb8A",
"SymbiosisFacet": "0x21571D628B0bCBeb954D5933A604eCac35bAF2c7",
"AcrossFacetV3": "0xe2e5428F972d9C0a5Ba433e0c402752b472dB248",
"Permit2Proxy": "0x6FC01BC9Ff6Cdab694Ec8Ca41B21a2F04C8c37E5"
}
"AcrossFacetV3": "0xAd99305a4277B417d1711CB358Dcf124181Ec3C3",
"Permit2Proxy": "0x6FC01BC9Ff6Cdab694Ec8Ca41B21a2F04C8c37E5",
"AcrossFacetPackedV3": "0x21767081Ff52CE5563A29f27149D01C7127775A2",
"ReceiverAcrossV3": "0xe4F3DEF14D61e47c696374453CD64d438FD277F8"
}
Loading
Loading