Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for transaction helper functions #101

Closed
coderabbitai bot opened this issue Dec 2, 2024 · 1 comment
Closed

Add unit tests for transaction helper functions #101

coderabbitai bot opened this issue Dec 2, 2024 · 1 comment
Assignees
@fmorency

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2024

The functions getTransactionIcon, getTransactionMessage, getTransactionPlusMinus, and getTransactionColor in historyBox.tsx need unit tests to ensure reliability and prevent future regressions.

Related PR: #98
Related Comment: #98 (comment)

Requested by: @fmorency
@fmorency
Copy link
Contributor

fmorency commented Dec 2, 2024 •
edited
Loading

Those getters are private methods. We should test those using public interfaces.

@fmorency fmorency closed this as completed Dec 2, 2024
@coderabbitai coderabbitai bot mentioned this issue Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmorency fmorency

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmorency