Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promp the user to sign on HW wallet #240

Closed
fmorency opened this issue Feb 5, 2025 · 0 comments · Fixed by #275
Closed

Promp the user to sign on HW wallet #240

fmorency opened this issue Feb 5, 2025 · 0 comments · Fixed by #275
Assignees
@hansl
Labels
enhancement New feature or request

Comments

@fmorency
Copy link
Contributor

fmorency commented Feb 5, 2025

  1. Log in using the Ledger wallet
  2. Send some MFX to some address

There's no indication that the user needs to sign the transaction on its device after clicking the Send button. We should make it more obvious.
@fmorency fmorency added the enhancement New feature or request label Feb 5, 2025
hansl added a commit to hansl/manifest-app that referenced this issue Feb 8, 2025
@hansl
Refactor the sendForm and TailwindDialog to use <dialog> tags
1a0d73e 
This makes it more streamline that we have a stack of dialogs during the
"Send Assets" UX flow. Showing multiple dialogs at once and pressing
Escape will close the latest opened one. Same with closing dialogs.

This is preliminary work to fix liftedinit#240.
@hansl hansl mentioned this issue Feb 8, 2025
Merged
hansl added a commit to hansl/manifest-app that referenced this issue Feb 13, 2025
@hansl
Use a single isSigning state across the app
beee51c 
This makes a lot of state keeping simpler regarding signing. Now
the components just use "isSigning" from "useTx" and they will all
sync up if there is a signature going on.

This is preliminary work for liftedinit#240
@hansl hansl mentioned this issue Feb 13, 2025
Merged
fmorency pushed a commit that referenced this issue Feb 13, 2025
@hansl
chore: use a single signing state across the app (#273)
18e9acb 
This makes a lot of state keeping simpler regarding signing. Now
the components just use "isSigning" from "useTx" and they will all
sync up if there is a signature going on.

This is preliminary work for #240
hansl added a commit to hansl/manifest-app that referenced this issue Feb 13, 2025
@hansl
Add a signing message dialog for Ledger users to check their device
ff7482f 
It is not dismissable until the user either approve, reject, reload the page, or
unplug the ledger, or any other OhMyGodWhatAreYouDoing action.

Fixes liftedinit#240
hansl added a commit to hansl/manifest-app that referenced this issue Feb 13, 2025
@hansl
Add a signing message dialog for Ledger users to check their device
12d8869 
It is not dismissable until the user either approve, reject, reload the page, or
unplug the ledger, or any other OhMyGodWhatAreYouDoing action.

Fixes liftedinit#240
@hansl hansl mentioned this issue Feb 13, 2025
Merged
@hansl hansl closed this as completed in 74ee6c5 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansl hansl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a signing message dialog for Ledger users to check their device hansl/manifest-app
2 participants
@hansl @fmorency