Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use llvm::StringRef instead of std::string in ghidra::mlir_codegen_visitor::memory_t. #18

Open
surovic opened this issue Jun 18, 2024 · 0 comments
Open

Use llvm::StringRef instead of std::string in ghidra::mlir_codegen_visitor::memory_t. #18

surovic opened this issue Jun 18, 2024 · 0 comments
Milestone
1.B P-Code MLIR D...

Comments

@surovic
Copy link
Contributor

surovic commented Jun 18, 2024 •
edited
Loading

Cannot we just use llvm::StringRef instead of std::string? It provides default DenseMapInfo and also is more lightweight. Is memory_t supposed to be responsible for name lifetime? I would expect it is hold by operation

Originally posted by @xlauko in #2 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.B P-Code MLIR Dialect and Translation
Development

No branches or pull requests
2 participants
@xlauko @surovic