Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error description on invalid email link in paradoxValidateLinks #411

Open
Dollyg opened this issue Feb 17, 2020 · 2 comments
Open

Bad error description on invalid email link in paradoxValidateLinks #411

Dollyg opened this issue Feb 17, 2020 · 2 comments

Comments

@Dollyg
Copy link

Dollyg commented Feb 17, 2020

I have this text in my docs [email protected] which is not a valid email link.

The error I get is very undescriptive.

(docs / Paradox / paradoxValidateLinks) java.lang.IllegalArgumentException: Illegal character in fragment at index 15: mailto:x@y.z

Having atleast filename, linenumber would be very helpful.

@raboof
Copy link
Contributor

raboof commented Feb 17, 2020

I agree! Would you be interested in trying to improve this? I think an ErrorContext is available during most of the validation, if you can catch this IllegalArgumentException and report it through ErrorContext, including the file that is being validated, that should help it report a better error.

@Dollyg
Copy link
Author

Dollyg commented Feb 17, 2020

Will definitely give it a try. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants