Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI with Node16-compatible actions #1778

Closed
tnull opened this issue Oct 18, 2022 · 4 comments · Fixed by #2396
Closed

Update CI with Node16-compatible actions #1778

tnull opened this issue Oct 18, 2022 · 4 comments · Fixed by #2396

Comments

@tnull
Copy link
Contributor

tnull commented Oct 18, 2022

Github recently announced the deprecation of Node12-based actions.

We should upgrade all actions of the CI to stop them complaining.

Currently blocked on actions-rs/toolchain#220.

@TheBlueMatt
Copy link
Collaborator

WTH? Why is there any node.js in any of our CI? That's bonkers...

Also, I really love that issue:

I would argue that this is why we need repos like this to be run as DAOs.

@arik-so
Copy link
Contributor

arik-so commented Dec 16, 2022

There's also the whole set-output thing that's Github's complaining about that doesn't appear like it should be an issue: https://github.com/actions/toolkit/blob/819157bf872a49cfcc085190da73894e7091c83c/packages/core/src/core.ts#L192

It also seems entirely due to actions-rs/toolchain, which is calling actions/core's setOutput command in multiple places in this file, starting here: https://github.com/actions-rs/toolchain/blob/88dc2356392166efad76775c878094f4e83ff746/src/versions.ts#L72

@arik-so
Copy link
Contributor

arik-so commented Dec 16, 2022

Considering actions-rs/toolchain specifies the @actions/core dependency as ^1.2.6, and the latest version of @actions/core is 1.10.0, I don't quite see why we're getting the set-output error message from Github all the time.

@arik-so
Copy link
Contributor

arik-so commented Dec 16, 2022

We could temporarily just fork actions-rs/toolkit and run that with PR 220 applied? It doesn't look like svartalf is coming online anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants